1948239 - One-time crash [@ OOM | large | NS_ABORT_OOM | nsTSubstring<T>::AllocFailed | CopyASCIItoUTF16 | mozilla::dom::CharacterData::SubstringData ]

Status: REOPENED

(Core :: DOM: Navigation, defect)

Description

[Mayank Bansal]

Was trying out the text-fragment thingy and got this crash once. Havent been able to repro.
Make what you will of this.

Comment 1

[Jan Jaeschke [:jjaschke]]

Depending on the hardware and use case this might happen, yes. The algorithm to create a text fragment trades off memory for being fast. I do have some ideas how to use less CPU time if there are many candidates to consider, which might help with this. But currently, I don't think this is actionable.

Comment 2

[Mayank Bansal]

Attachment: about:support

Comment 3

[Mayank Bansal]

This crash is now easy to repro on large pages like https://en.wikipedia.org/wiki/Barack_Obama.

STR:

1. Enable the text-fragment thingy
2. Go to https://en.wikipedia.org/wiki/Barack_Obama
3. Search for this string: Wallace-Wells, Benjamin (November 2004
4. Select the whole reference #416
5. Right click to activate the creation of text fragment

• AR: OOM crash
• ER: Not so

Specially worrisome because the combination of 5-second rule and the un-interruptible nature of this search makes it so that if a user right clicks on a page, the browser will quickly eat up a lot of RAM and crash, while the user thinks everything is normal becuase they have closed the context menu or navigated away from the tab.

IMHO, the runaway memory use must be fixed before this feature is enabled on Nightly. I am politely reopening this bug just this time, but please close as you think appropriate.

Comment 4

[Jan Jaeschke [:jjaschke]]

Hm, while I believe you that it happened, I can't repro. With the STR you posted the context menu item is activated instantly, I can't notice it being disabled. Memory imprint also seems fine (and, fwiw, I tested this on the HTML Spec, which is a few orders of magnitude larger...).
Did you try this with today's Nightly?

Comment 5

[Mayank Bansal]

This is wht i get with the latest Nightly :https://share.firefox.dev/41wq3EU on a fresh profile. Memory reached 5gb+ and I think then some internal memory limit was reached.

STR is to create a fragment of the whole reference #416 on the Obama wiki page (triple click on the reference #416 to select all its text)