Closed Bug 1948265 Opened 1 month ago Closed 21 days ago

The "Find your open groups on the tab bar or by searching for them in the address bar" callout is displayed in the wrong position with RTL builds

Categories

(Firefox :: Messaging System, defect, P1)

Desktop
Unspecified
defect
Points:
1

Tracking

()

VERIFIED FIXED
Tracking Status
firefox-esr128 --- disabled
firefox135 --- disabled
firefox136 --- disabled
firefox137 --- verified

People

(Reporter: rdoghi, Assigned: emcminn)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Found in

  • Nightly 137.0a1 (2025-02-13)

Affected versions

  • Nightly 137.0a1 (2025-02-13)
  • Beta 136.0b5

Affected platforms

  • All

Steps to reproduce

  1. Create a Tab group with the name Best.

Expected result

  • The "Find your open groups on the tab bar or by searching for them in the address bar" Callout should be displayed next to the Lock Icon in the address bar.

Actual result

  • The Callout is displayed towards the end of the address bar with RTL builds

Regression range
Not a regression.

I thought we wanted to point towards the middle of the address bar, so not sure that we really have a bug here. The screenshot looks roughly as expected to me.

Blocks: 1907535
Component: Tabbed Browser → Messaging System
Flags: needinfo?(amlee)
Flags: needinfo?(amlee)
Assignee: nobody → emcminn
Severity: -- → S3
Status: NEW → ASSIGNED
Points: --- → 1
Priority: -- → P1

This should be fixed by the patch for bug 1949261, which adjusts the callout positioning to be centered on the address bar in both LTR and RTL orientations.

Status: ASSIGNED → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED

Hi @Emily, if we dont have the List all tabs menu and we create a Tab group, the "Find your groups by searching for them in the address bar" callout is displayed in the middle of the address bar, however in the Figma file of the Bug 1949261 that you mentioned, the Callouts are never displayed in the middle of the address bar, at best with Vertical tabs enabled its displayed right next to the Sidebar but its still not in the middle of the address bar.

Is the Figma outdated ?

Flags: needinfo?(emcminn)

Hi Rares, yes, for the cases where the TOM (alltabs) button is removed, we decided to go with the center of the address bar. https://mozilla.slack.com/archives/C06PKPZMVLK/p1739913396525169 is the relevant Slack conversation, I didn't realize the Figma never got updated!

Flags: needinfo?(emcminn)

Thanks for the update, This issue is Verified as fixed in our latest Nightly builds, I will update the flags.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: