1948325 - [wpt-sync] Sync PR 50715 - [Editing] Include open shadow roots in RangeLength for MoveParagraphs.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50715 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50715
Details from upstream follow.

Shweta Bindal <[e-mail]> wrote:

[Editing] Include open shadow roots in RangeLength for MoveParagraphs.

When we toggle off list, it executes |MoveParagraphs| function. In that
while calculating |EphemeralRange| and |destination_index|, the iterator
does not go in shadow root. To change this |TextIteratorBehavior| should
be |enters_open_shadow_roots| true. This was done by using
|SetEntersOpenShadowRoots| function.

The |shadow_depth_| check was removed from the while condition, as it
was causing the loop to iterate over all nodes within the shadow root.
This behavior resulted in a failure of the |Dcheck| when the node
exceeded the |past_end| boundary.

Low-Coverage-Reason: HARD_TO_TEST
Bug: 40771555
Change-Id: Iec5924f478df68379cfbdaad60a5a76658a00f2a

Reviewed-on: https://chromium-review.googlesource.com/6197017
WPT-Export-Revision: 62ad4dfcc92e8f9dc1f81d8c14eebaf252a9b899

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ac3687d1e9adc55686ae2cb68f98e124269c430

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d162cec2fe1
[wpt PR 50715] - [Editing] Include open shadow roots in RangeLength for MoveParagraphs., a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8d162cec2fe1