1948417 - Intermittent TV leakcheck | default 1232 bytes leaked (CondVar, MozPromise::ThenValueBase::ResolveOrRe, MozPromiseRefcountable, Mutex, StringBuffer, ...)

Status: RESOLVED FIXED

(Firefox :: Data Loss Prevention, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: agoloman [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=495058656&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/W0xWtt5NTpOgzKotEvqs0w/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/W0xWtt5NTpOgzKotEvqs0w/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2025-02-14T21:59:26.911Z] 21:59:26     INFO - TEST-INFO | leakcheck | utility process: leak threshold set at 0 bytes
[task 2025-02-14T21:59:26.912Z] 21:59:26     INFO - leakcheck | Processing leak log file C:\Users\task_173956610911756\AppData\Local\Temp\tmpz2zm7fxc.mozrunner\runtests_leaks.log
[task 2025-02-14T21:59:26.913Z] 21:59:26     INFO - 
[task 2025-02-14T21:59:26.913Z] 21:59:26     INFO - == BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS, default process 8612
[task 2025-02-14T21:59:26.914Z] 21:59:26     INFO - 
[task 2025-02-14T21:59:26.914Z] 21:59:26     INFO -      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
[task 2025-02-14T21:59:26.914Z] 21:59:26     INFO -      |                                      | Per-Inst   Leaked|   Total      Rem|
[task 2025-02-14T21:59:26.915Z] 21:59:26     INFO -    0 |TOTAL                                 |       29     1232| 5996759       68|
[task 2025-02-14T21:59:26.915Z] 21:59:26     INFO -  198 |CondVar                               |       36       36|    1102        1|
[task 2025-02-14T21:59:26.916Z] 21:59:26     INFO -  645 |MozPromise::ThenValueBase::ResolveOrRe|       20      400|    1374       20|
[task 2025-02-14T21:59:26.917Z] 21:59:26     INFO -  646 |MozPromiseRefcountable                |        8      168|    3538       21|
[task 2025-02-14T21:59:26.917Z] 21:59:26     INFO -  650 |Mutex                                 |       44      132|   12758        3|
[task 2025-02-14T21:59:26.918Z] 21:59:26     INFO - 1251 |StringBuffer                          |        8      160| 1023374       20|
[task 2025-02-14T21:59:26.918Z] 21:59:26     INFO - 1304 |ThreadEventTarget                     |       24       24|      70        1|
[task 2025-02-14T21:59:26.919Z] 21:59:26     INFO - 1309 |ThreadTargetSink                      |        8        8|      70        1|
[task 2025-02-14T21:59:26.919Z] 21:59:26     INFO - 2049 |nsThread                              |      304      304|      85        1|
[task 2025-02-14T21:59:26.920Z] 21:59:26     INFO - 
[task 2025-02-14T21:59:26.920Z] 21:59:26     INFO - nsTraceRefcnt::DumpStatistics: 2154 entries
[task 2025-02-14T21:59:26.921Z] 21:59:26     INFO - TEST-INFO | leakcheck | default leaked 1 CondVar
[task 2025-02-14T21:59:26.922Z] 21:59:26     INFO - TEST-INFO | leakcheck | default leaked 20 MozPromise::ThenValueBase::ResolveOrRe
[task 2025-02-14T21:59:26.922Z] 21:59:26     INFO - TEST-INFO | leakcheck | default leaked 21 MozPromiseRefcountable
[task 2025-02-14T21:59:26.923Z] 21:59:26     INFO - TEST-INFO | leakcheck | default leaked 3 Mutex
[task 2025-02-14T21:59:26.923Z] 21:59:26     INFO - TEST-INFO | leakcheck | default leaked 20 StringBuffer
[task 2025-02-14T21:59:26.924Z] 21:59:26     INFO - TEST-INFO | leakcheck | default leaked 1 ThreadEventTarget
[task 2025-02-14T21:59:26.924Z] 21:59:26     INFO - TEST-INFO | leakcheck | default leaked 1 ThreadTargetSink
[task 2025-02-14T21:59:26.925Z] 21:59:26     INFO - TEST-INFO | leakcheck | default leaked 1 nsThread
[task 2025-02-14T21:59:26.925Z] 21:59:26     INFO - TEST-UNEXPECTED-FAIL | leakcheck | default 1232 bytes leaked (CondVar, MozPromise::ThenValueBase::ResolveOrRe, MozPromiseRefcountable, Mutex, StringBuffer, ...)
[task 2025-02-14T21:59:26.926Z] 21:59:26     INFO - 
[task 2025-02-14T21:59:26.926Z] 21:59:26     INFO - leakcheck | Processing leak log file C:\Users\task_173956610911756\AppData\Local\Temp\tmpz2zm7fxc.mozrunner\runtests_leaks_gpu_pid3468.log
[task 2025-02-14T21:59:26.927Z] 21:59:26     INFO - TEST-PASS | leakcheck | gpu no leaks detected!

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:gstoll, since you are the author of the regressor, bug 1938188, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1938188

Comment 3

[Intermittent Failures Robot]

Summary

2 failures in 5022 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform and build breakdown:

• windows11-32-24h2: 1
  • debug: 1
• windows11-64-24h2: 1
  • debug: 1

Table

	no_variant
windows11-32-24h2--/debug	1
windows11-64-24h2--/debug	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1948417&startday=2025-02-10&endday=2025-02-16&tree=all

Comment 4

[Greg Stoll :gstoll]

I can reproduce this by just running the testClipboardWithContentAnalysisBlockCheckAllFormats() task.

I'm a bit surprised that bug 1938188 caused this - I'd be more suspicious of bug 1936020, and indeed it looks like it had a similar test-verify leak on autoland.

Anyway, I'll take a look.

Comment 5

[Greg Stoll :gstoll]

My guess is this has something to do with the way we cancel other requests when we get a BLOCK response, since the testClipboardWithContentAnalysisBlockCheckAllFormats() task is the only one that triggers that behavior. It looks like we're leaking a MozPromise somehow.

Comment 6

[Greg Stoll :gstoll]

Indeed, if I instead early return from MultipartRequestCallback::ContentResult() if there are requests outstanding even if the response is BLOCK, the leak goes away. So this is tied up in CancelRequests() somehow.

Comment 7

[David Parks [:handyman]]

Attachment: Bug 1948417: Delegate CancelRequests call to mock content analysis service in tests r=#dlp-reviewers!

This also checks that it is called in the clipboard test. (Other tests could
be made to check this as well. This is future work.)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22962c25d0e8
Delegate CancelRequests call to mock content analysis service in tests r=dlp-reviewers,gstoll

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/22962c25d0e8