1948721 - Add telemetry about how frequently we clear push subscription by site data cleanup

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

To decide what to do with Declarative Web Push.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

BTW, for mobile we do nothing: https://searchfox.org/mozilla-central/rev/7b3f3fb5fd2cad8f348131498a35a91bef68b47b/mobile/shared/components/geckoview/GeckoViewPush.sys.mjs#147-153

  clearForDomain(domain, originAttributesPattern, callback) {
    callback.onClear(Cr.NS_OK);
  }

  clearForPrincipal(principal, callback) {
    callback.onClear(Cr.NS_OK);
  }

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1948721 - Add telemetry for unsubscriptions by clearing site data r=asuth

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Kagami Rosylight [:saschanaz] (they/them) from comment #1)

BTW, for mobile we do nothing: https://searchfox.org/mozilla-central/rev/7b3f3fb5fd2cad8f348131498a35a91bef68b47b/mobile/shared/components/geckoview/GeckoViewPush.sys.mjs#147-153

So in this case we'll expect that the ServiceWorker will be gone even though we might still receive pushes, so there will be no ServiceWorker to wake up? (Noting that ServiceWorkerManager definitely won't go looking to install a ServiceWorker if the registration is gone.)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48a6708ddfbe
Add telemetry for unsubscriptions by clearing site data r=asuth

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/48a6708ddfbe

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

(In reply to Andrew Sutherland [:asuth] (he/him) from comment #3)

(In reply to Kagami Rosylight [:saschanaz] (they/them) from comment #1)

BTW, for mobile we do nothing: https://searchfox.org/mozilla-central/rev/7b3f3fb5fd2cad8f348131498a35a91bef68b47b/mobile/shared/components/geckoview/GeckoViewPush.sys.mjs#147-153

So in this case we'll expect that the ServiceWorker will be gone even though we might still receive pushes, so there will be no ServiceWorker to wake up? (Noting that ServiceWorkerManager definitely won't go looking to install a ServiceWorker if the registration is gone.)

Seems yes, unless Fenix does something extra to clear things up.

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1948721 - Add telemetry for unsubscriptions by clearing site data r=asuth

Original Revision: https://phabricator.services.mozilla.com/D238623

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: None; we only want to learn how frequently unsubscriptions happen to decide on upcoming feature
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: None
• Explanation of risk level: only adding telemetry
• String changes made/needed: N/A
• Is Android affected?: no

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9468175 [details]
Bug 1948721 - Add telemetry for unsubscriptions by clearing site data r=asuth

Fx136 is now in release for RC week. Moving the uplift request.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/bca7504f641c