Closed Bug 1948735 Opened 27 days ago Closed 25 days ago

[wpt-sync] Sync PR 50753 - Resolve css scale interpolation number before interpolation

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50753 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50753
Details from upstream follow.

Daniil Sakhapov <sakhapov@chromium.org> wrote:

Resolve css scale interpolation number before interpolation

This is done to fix the case when we have a neutral frame, which will
end up being a number type and some percentage frame, but we are not
allowed to sum number and percentage.
So the fix is to resolve percentage to number before interpolation.
It can give incorrect result if values
have some relative units inside that are also being interpolated.

We would be able to do it properly by dividing the percentage part
by 100% during interpolation, once we can divide units properly,
so leaving TODO for now.

Fixed: 396584141
Change-Id: Iac9e16047237264e3fd56b5dfb9e4f0f2684c6c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6276493
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Daniil Sakhapov \<sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421095}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7cbe3786252e [wpt PR 50753] - Resolve css scale interpolation number before interpolation, a=testonly
Status: NEW → RESOLVED
Closed: 25 days ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.