194876 - Want tree attribute for column picker tooltip text

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[[e-mail]]

Spun off from bug 112264.
MailNews wants the column picker to have a tooltip.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Jan Varga [:janv]]

Comment on attachment 115520 [details] [diff] [review]
Proposed patch

r=varga

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 115520 [details] [diff] [review]
Proposed patch

sr=sspitzer

thanks neil (and jan, for the review)

Comment 4

[[e-mail]]

Fix checked in.

Comment 5

[[e-mail]]

Really marking checked in... apologies...

Comment 6

[parish]

Attachment: Screenshot showing rogue tooltip

There appears to be some brokeness with this. The tooltip appears in the
correct place when hovering over the column picker *button*, but hovering over
any menu item causes the same tooltip to appear, but in the wrong place. See
attached screenshot.

I initially thought that I'd broken this whilst fixing bug 173874 but backing
out that patch (and the fix for bug 73970, which highlighted bug 173874) from
my tree showed that I hadn't.

What I did find was that in nsMenuPopupFrame::SyncViewWithFrame() parentPos is
0,0 for the column picker menu tooltips, which seems wrong.

Comment 7

[[e-mail]]

That's nothing. Open the File toolbarbutton menu, then hover over something else
with a tooltip, then hover over the menu, you get the same tooltip :-)

Comment 8

[parish]

But at least it's in the correct place :-)

In fact you don't even need to open the File tool bar button menu first; you can
open it after hovering over something else, provided you open the menu before
the File button tooltip appears.

Seriously, this all seems rather pointless. Why do the menu items have tooltips
at all, since they are the same as the button's tooltip? They appear to be just
inheriting the tooltip from the parent. Can this behaviour be suppressed?