1948992 - [wpt-sync] Sync PR 50776 - [functions] Validate dashed-functions parse-time

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50776 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50776
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[functions] Validate dashed-functions parse-time

We currently accept any token sequence in the argument list
of a dashed function, but really it should be \<declaration-value>#.
The \<declaration-value> production does impose a few restrictions
on what is allowed, e.g. top-level semicolon tokens.

Bug: 325504770, 390205875
Change-Id: I5766a4edc58c1caf448097c4270bcfa2f210b4f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6275933
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Reviewed-by: Steinar H Gunderson \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1421440}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd8edf9f49c9cfbba57b14b7cb2a6841de5c4a2f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 27 subtests

Status Summary

Firefox

OK : 1
PASS: 17
FAIL: 10

Chrome

OK : 1
PASS: 15
FAIL: 12

Safari

OK : 1
PASS: 17
FAIL: 10

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-mixins/dashed-function-parsing.html [wpt.fyi]
  • e.style['top'] = "--func()" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['top'] = "--func(auto)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['top'] = "--func(100px)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['top'] = "--func(#fff)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['top'] = "--func(auto, 100px, #fff)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['top'] = "--func(auto ,100px ,#fff)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['top'] = "--func(auto , 100px , #fff)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['top'] = "--func(auto,100px,#fff)" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['top'] = "--func("thing")" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
  • e.style['top'] = "--func(--bar(), --baz(--fez()))" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cf624c300c4
[wpt PR 50776] - [functions] Validate dashed-functions parse-time, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7490c763ef48
[wpt PR 50776] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2cf624c300c4
https://hg.mozilla.org/mozilla-central/rev/7490c763ef48

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2cf624c300c4
https://hg.mozilla.org/mozilla-central/rev/7490c763ef48