Closed Bug 1948999 Opened 1 year ago Closed 1 year ago

Newtab inferred personalization UI and card

Categories

(Firefox :: New Tab Page, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
139 Branch
Tracking Status
firefox139 --- fixed

People

(Reporter: thecount, Assigned: rhamoui)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(1 file)

This is to build the card UI as in the comps.

Blocks: 1949000
Assignee: nobody → rhamoui
Attachment #9467788 - Attachment description: WIP: Bug 1948999 - Add inferred personalization UI card. → Bug 1948999 - Add inferred personalization UI card. r=#home-newtab-reviewers
Pushed by rhamoui@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5da7bd48474e Add inferred personalization UI card. r=home-newtab-reviewers,frontend-codestyle-reviewers,npypchenko

Backed out for causing newtab failures.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/extensions/newtab | Coverage for statements (33.33%) in file /builds/worker/checkouts/gecko/browser/extensions/newtab/content-src/components/DiscoveryStreamComponents/PersonalizedCard/PersonalizedCard.jsx does not meet per file threshold (90.48%)
Flags: needinfo?(rhamoui)
Depends on: 1961070
Pushed by rhamoui@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec50101b9699 Add inferred personalization UI card. r=home-newtab-reviewers,frontend-codestyle-reviewers,npypchenko

Backed out for causing newtab failure

Backout link

Push with failures

Failure log

Pushed by sdowne@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fd1b6dc001df Add inferred personalization UI card. r=home-newtab-reviewers,frontend-codestyle-reviewers,npypchenko
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
Flags: needinfo?(rhamoui)

(In reply to Norisz Fay [:noriszfay] from comment #5)

Backed out for causing newtab failure

Backout link

Push with failures

Failure log

Perfherder has detected a devtools performance change from push c0034a4f73bc5d68350756468db5bd855553aa22.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
2% damp console.autocomplete linux1804-64-shippable-qr e10s fission stylo webrender 633.97 -> 620.53

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 44807

The following documentation link provides more information about this command.

Keywords: perf-alert
QA Whiteboard: [qa-triage-done-c140/b139]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: