1949125 - Search mode chiclet label for restricted search keyword remains untranslated for some locales

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Attachment: history chiclet in ro locale

Found in

• 136.0 beta 6

Affected versions

• 137.0a1 (2025-02-18)
• 136 beta 7

Tested platforms

• Affected platforms: Windows 11, Mac 13, Ubuntu 24

Preconditions:

• For late beta, set browser.urlbar.scotchBonnet.enableOverride to true.
• Download any of the following locales: ach, af, an, ar, ast, az, ro, etc.

Steps to reproduce

1. Type in address bar @bookmarks / @tabs / @history / @actions - either in English or in the localized language
2. Should list the restrict keywords result as @localizedkeyword, @englishKeyword - Search <Localized Search Mode>.
3. Use Enter, right arrow, Space or Tab to enter restrict keyword search mode.

Expected result
3. Search mode chiclet label is displayed in the localized language.

Actual result
3. Search mode chiclet label is displayed in English, even if the restricted keywords are correctly translated (during step 2)..

Regression range

• Probably a follow-up from bug 1933003.

Note

• This issue is not present for other locales like de, fr, it, es-ES, zh-CN, etc.
• It might be related to translation, but we couldn't find a way to confirm this.

Comment 1

[Mandy Cheang [:mcheang][she/her]]

Hi Petruta,
The issue is related to translation. I've checked on Pontoon, this is the web localization system we use to do the translations.

These strings here haven't been translated in ro yet.

Whereas, I've checked es-ES and it has been translated by the community. I've attached some screenshots to show the difference.

Comment 2

[Mandy Cheang [:mcheang][she/her]]

Attachment: untranslated-ro.png

Comment 3

[Mandy Cheang [:mcheang][she/her]]

Attachment: translated-es-ES.png

Comment 4

[Petruta Horea [:phorea], Desktop Test Engineering]

Attachment: @ dropdown, preferences

Thank you for checking, Mandy!

Just to be clear, the strigs are translated in dropdown / preferences.

Comment 5

[Mandy Cheang [:mcheang][she/her]]

Got it. Strings are translated in dropdown / preferences.

Thank you for filing this bug. I'm following up with l10n team on Slack to understand what's the best thing to do here. These strings were translated previously.

The untranslated strings for ach, af, an, ar, ast, az, ro, etc. were added in October 2024 (reference), but the same strings were previously translated and were added in 2020 (reference). I'll see what translation team suggestions and follow up when they reply.

Comment 6

[Mandy Cheang [:mcheang][she/her]]

The l10n team responded and they recommend if there are strings with the same message, we should perform a migration: https://firefox-source-docs.mozilla.org/l10n/migrations/fluent.html

They went ahead and did the migration for us.
The strings should now be translated for the following locales: ach, af, an, ar, ast, az, ro, etc.

Could you please test this again and see if you're getting the expected results?

Comment 7

[Petruta Horea [:phorea], Desktop Test Engineering]

(In reply to Mandy Cheang [:mcheang][she/her] from comment #6)

Could you please test this again and see if you're getting the expected results?

Thank you for following up on this.

In Firefox 136 beta 9, the chiclet labels are still not translated, but I'm unaware if the migration that l10n team did, is propagated immediately (just like a Remote Settings change would work on production) or if it rides the trains or maybe it is a different delivery mechanism.

Comment 8

[James Teow [:jteow]]

Mandy, we're just looking at this in our bug scrub. Do you know how l10n does the migration? Does it just land on central and ride the train and thus wouldn't automatically affect beta?

Comment 9

[Mandy Cheang [:mcheang][she/her]]

l10n team does a different delivery process using the l10n bumper. This will bump the l10n changesets once per day.

When I ask their team about not seeing the translations on beta 9, the reason for that is the changes didn't make it for the cutoff for beta 9.

However, the changeset that includes the updated translation has been pumped to a version after the migration, so the translations should be included at the time of the 136 Release Candidate build. An uplift is not necessary.

Maybe we can test again once 136 RC is built.

Comment 10

[Petruta Horea [:phorea], Desktop Test Engineering]

I can confirm that the translated strings are correctly displayed in search mode chiclet in 136RC, for the localizations where they are available.

Comment 11

[Yazan Al Macki [:yazan]]

Hi Mandy, could you please close this bug if the issue has been fixed.

Comment 12

[Mandy Cheang [:mcheang][she/her]]

I'm not sure if this is fixed yet.
Just wanted to double check:

Petruta, did you already test this on 136RC and it's good? Or are you still working on testing it?

Comment 13

[Mandy Cheang [:mcheang][she/her]]

I tested it out in 136 today. Translations are applied.