Closed Bug 1949142 Opened 1 month ago Closed 23 days ago

[wpt-sync] Sync PR 50795 - Simplify corner-shape inset formula

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
137 Branch
Tracking Flags:
Tracking Status
firefox137 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50795 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50795
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

Simplify corner-shape inset formula

Undo the slope calculation which was done for uneven radius (e.g. due to
percentage), as this would be incompatible with existing border-radius
rendering.

Instead, compute a simple offset based on the curvature and border width
only.

This would mean that elliptical corners would still look "scaled", but
square corners would have the correct width.

Bug: 394059604
Change-Id: If95876d166fdf7c2a83c3b1853e5be6cbb4bf657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6280666
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1421844}

PR 50795 applied with additional changes from upstream: cd546585e048de3c88ffdaa7f83e23f4a0dba932
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests

Status Summary

Firefox

FAIL: 9

Chrome

FAIL: 9

Safari

FAIL: 9

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dae37e8d14b7 [wpt PR 50795] - Simplify corner-shape inset formula, a=testonly https://hg.mozilla.org/integration/autoland/rev/50a6cac39cd8 [wpt PR 50795] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/dae37e8d14b7
https://hg.mozilla.org/mozilla-central/rev/50a6cac39cd8

Status: NEW → RESOLVED
Closed: 23 days ago
status-firefox137: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
You need to log in before you can comment on or make changes to this bug.