194921 - Save Page As fails to save anything

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Tracy Walker [:tracy]]

seen on mac commercial and mozilla builds 2003-02-25-03-trunk

-Browse a web page
-select File | Save Page As
-use web complete...Save page

tested results: nothing is saved.

expected results:  the web page and an associated folder are saved.

note: this seems to be mac only...linux build 2003-02-25-08-trunk works fine. 
no windows build yet

Comment 1

[Boris Zbarsky [:bzbarsky]]

Are you using download manager or progress dialog?

Comment 2

[Tracy Walker [:tracy]]

Save As dialog

Comment 3

[Boris Zbarsky [:bzbarsky]]

any errors in the JS console?  Does using download manager work ok?

Comment 4

[Tracy Walker [:tracy]]

Using progress dialog for Save As is broken

workaround: Select open the download manager in preferences | Navogator
Downloads. This saves the page and associatd files as expected.

can this be a valid workaround, or is the "progress dialog" failure a blocker on
its own?

Comment 5

[Boris Zbarsky [:bzbarsky]]

It's a blocker on its own, imo.  So to repeat, any errors in the JS console?  ;)

See also the checkin I made at 8:09am this morning; that was supposed to fix the
exact issue you're seeing...  I just noticed that the mac build you tested on is
from way before then; any chance of retesting with an 8am or later mac build?

Comment 6

[Sven Grull]

Same problem with windows 2003022508

JS console:
Error: [Exception... "Component returned failure code: 0x80040154
(NS_ERROR_FACTORY_NOT_REGISTERED) [nsIDownload.init]"  nsresult: "0x80040154
(NS_ERROR_FACTORY_NOT_REGISTERED)"  location: "JS frame ::
chrome://communicator/content/contentAreaUtils.js :: foundHeaderInfo :: line
380"  data: no]
Source File: chrome://communicator/content/contentAreaUtils.js
Line: 380

Comment 7

[Boris Zbarsky [:bzbarsky]]

Does that build have the 8:09 patch in it?  (unjar the relevant jar and check)

Comment 8

[Sven Grull]

The patch in nsProgressDialog.js is not in this build, still seeing break
instead of return.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Ok.  Does switching it to return make the problem go away?  Or should I back out
the checkin for bug 91969?

Comment 10

[Boris Zbarsky [:bzbarsky]]

Ok... I'm not sure how the tree opened with a pending smoketest blocker, but....
Is this still an issue with a Feb 26 build?

Comment 11

[sairuh (rarely reading bugmail)]

tracy, how does this work with today's mozilla bits?

Comment 12

[Tracy Walker [:tracy]]

works with todays mac mozilla build 2003-02-26-03-trunk (progress dialog
selected in prefs)

Comment 13

[Chris McAfee]

bill law not working on mozilla code.  Reassigning to samir to find a new owner
after talking with bill.

Comment 14

[Sven Grull]

WFM 2003022610 Win2000

Comment 15

[Chris McAfee]

samir says -> varga

Comment 16

[Boris Zbarsky [:bzbarsky]]

So.... if no one is seeing this bug anymore, why is it still open?  As I said in
comment 5, I landed a fix for this yesterday; I just needed to verify that it
was indeed fixed.

Comment 17

[Jan Varga [:janv]]

WFM, MacOS X, Build 2003022603

Comment 18

[Tracy Walker [:tracy]]

verified per comment #12