1949390 - With AgentTimeout set the content is allowed after meeting the agent delay time even if the DefaultResult is set to 1

Status: VERIFIED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: dlp_5.gif

Found in

• 137.0a1 (2025-02-20)

window

Affected versions

• 137.0a1 (2025-02-20)

Tested platforms

• Affected platforms: Windows 10x64, Windows 11
• Unaffected platforms: Ubuntu 24, macOS

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view
• Create a distribution folder inside the Firefox folder and paste the policies-4.json to it and then rename it to policies.json
• DLP Agent is running: .\content_analysis_sdk_agent.exe --user --toblock=.*\d{3}-?\d{2}-?\d{4}.* --towarn=.*warn.* --delays=10

Steps to reproduce

1. Paste a random string on the Wikipedia page.
2. Wait 10 seconds without choosing any option on the warn dialog.

Expected result

• The content is not pasted until an option is chosen on the Warn dialog.

Actual result

• The content is pasted without choosing any option.

Regression range

• New feature. Happens after the implementation on bug 1894538.

Additional notes

• Attached a screen recording.

Comment 1

[David Parks [:handyman]]

A WARN response needs to call Cancel on the timeout timer in mUserActionMap.Lookup(aUserActionId). That would be done here.

Comment 2

[David Parks [:handyman]]

Attachment: Bug 1949390: Cancel content analysis timeout timer when presenting warn dialog r=#dlp-reviewers!

We were timing out and enacting the timeout behavior while the user was
debating a response to the warn dialog.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/472494e6cbdf
Cancel content analysis timeout timer when presenting warn dialog r=dlp-reviewers,gstoll

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/472494e6cbdf

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! I have verified that the string is no longer pasted with Firefox 137.0a1 (20250221095438) on Windows 10x64 after following the steps from comment 0.
Just to be safe I understand this correctly now after the Agent reaches the timeout timer the request is blocked and the OS notification is displayed. In this situation the WARN dialog should not be displayed and the request should be automatically blocked even with browser.contentanalysis.default_result:1? Thank you!

Comment 6

[David Parks [:handyman]]

Hi atrif. The situation you are describing is how that works since bug 1944395 went in. After that bug, the pref that governs this is browser.contentanalysis.timeout_result -- the values have the same meaning as for the default_result pref. But if the timeout_result is set to warn then it should be showing the warn dialog.

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to David Parks [:handyman] from comment #6)

Hi atrif. The situation you are describing is how that works since bug 1944395 went in. After that bug, the pref that governs this is browser.contentanalysis.timeout_result -- the values have the same meaning as for the default_result pref. But if the timeout_result is set to warn then it should be showing the warn dialog.

Thank you for the response and sorry for late reply. I can confirm that with "TimeoutResult:1" policy the use content window is displayed and this issue is no longer reproducible with 137.0a1 (2025-02-27) on Windows 10x64.