1949415 - [macOS][Voiceover] Additional focus square on the top left of the first color in manage/create tab group panel

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: additional focus voiceover.png

Found in

• Nightly 137.0a1 (2025-02-19)

Affected versions

• Nightly 137.0a1 (2025-02-19)
• Beta 136.0b8

Affected platforms

• macOS

Preconditions

• Have voiceover active

Steps to reproduce

1. Access the create/manage tab group panel
2. Press tab to focus the color choices

Expected result

• There is one focus over the selected color

Actual result

• There is an additional fixed focus on the top left of the first color

Regression range

• Not a regression.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1949415 - Move color inputs off-screen. r=dwalker

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3cd7e3d9382
Move color inputs off-screen. r=dwalker,tabbrowser-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a3cd7e3d9382

Comment 5

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: image.png

Tried verifying the fix on Firefox 137.0a1 (treeherder build - 20250221095438) on macOS 15.3.1 and it seems that the little focus square is still there but outside the browser now. Any idea about it Dao? Thanks!

Comment 6

[Dão Gottwald [:dao]]

(In reply to Catalin Sasca, Desktop Test Engineering [:csasca] from comment #5)

Created attachment 9467696 [details]
image.png

Tried verifying the fix on Firefox 137.0a1 (treeherder build - 20250221095438) on macOS 15.3.1 and it seems that the little focus square is still there but outside the browser now. Any idea about it Dao? Thanks!

Good lord! Anna, any ideas for how to prevent this? :/

Comment 7

[Dão Gottwald [:dao]]

If we don't find a proper fix here, would you prefer I backed out https://hg.mozilla.org/mozilla-central/rev/a3cd7e3d9382? Not sure which behavior is worse.

Comment 8

[Morgan Reschenberg [:morgan]]

(In reply to Dão Gottwald [:dao] from comment #7)

If we don't find a proper fix here, would you prefer I backed out https://hg.mozilla.org/mozilla-central/rev/a3cd7e3d9382? Not sure which behavior is worse.

Does the functional behaviour differ between the two patches? e.g. does a user still select the swatch with the fx blue outline as they nav through the options even if the VO cursor box is offscreen?

Also, if the window is at the top of the screen, is there any on-screen VO cursor? or does the issue QA highlighted only happen when the window is not aligned to the menu bar?

Comment 9

[Morgan Reschenberg [:morgan]]

I think your patch's behaviour is better than the current behvaiour if (when the window is at the top of the screen) no VO cursor is rendered. This way users can depend on the fx blue focus outline instead and not be as confused by a nearby mis-placement of the VO cursor

Ideally though, it'd be nice to fix this. Do you have any more info on what the errant box is caused by?

Comment 10

[Dão Gottwald [:dao]]

(In reply to Morgan Reschenberg [:morgan] from comment #9)

I think your patch's behaviour is better than the current behvaiour if (when the window is at the top of the screen) no VO cursor is rendered. This way users can depend on the fx blue focus outline instead and not be as confused by a nearby mis-placement of the VO cursor

Okay, I'll close this again. Catalin, would you mind filing a new bug on the issue you found?

Ideally though, it'd be nice to fix this. Do you have any more info on what the errant box is caused by?

It's caused by our attempt to hide the input element, by moving it out of the window, and then presumably VoiceOver draws the rect. I'm not sure why we'd want this to be outside of the window though, so maybe that's something to fix in Gecko?

Comment 11

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Sure thing Dao. Here's the follow up bug.