Closed Bug 1949420 Opened 1 month ago Closed 11 days ago

Make toolbar context menu less compartmentalized after addition of vertical tabs option

Categories

(Firefox :: Toolbars and Customization, enhancement)

enhancement

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: dao, Unassigned)

References

Details

(Whiteboard: [fidefe-sidebar])

Spun off from bug 1946868:

Current toolbar context menu:

Pin to Overflow Menu
Remove from Toolbar
-----------------------
Menu Bar
Bookmarks Toolbar   >
-----------------------
Customize Toolbar...
-----------------------
Turn off Vertical Tabs
Customize Sidebar

Proposed toolbar context menu:

Pin to Overflow Menu
Remove from Toolbar
-----------------------
Menu Bar
Bookmarks Toolbar   >
Customize Toolbar...
-----------------------
Turn off Vertical Tabs
Customize Sidebar...

(In reply to Dão Gottwald [:dao] from bug 1946868 comment #12)

(In reply to Stuart Colville [:muffinresearch] from bug 1946868 comment #11)

Maybe this is a typo, but in comment #9 it looks like you're proposing removing a divider for the toolbar context menu and nothing else, is that right? It doesn't seem to match what was mentioned in comment 0.

I did say that I don't think we have a muscle memory problem in that menu, but that the semantic structure and hierarchy feels off. After playing around with options, I believe removing the separator between toolbar-focused items would be a good way to improve this. (Btw, I also added the ellipsis to "Customize Sidebar..." for consistency.) Does this make sense?

Yulia, what's your take on this?

To be clear, I don't think there's immediate pressure here like there was in bug 1946868. Improvements to this menu could just ride the release train without necessarily uplifting.

Flags: needinfo?(ypopova)
No longer depends on: 1946868
See Also: → 1946868

Hi Dao,
Thank you very much for your proposal. I'm not entirely sure which menu you are referring to. Currently, the right-click menu on the toolbar displays the following options:

Bookmarks Toolbar
__________________

Customize Toolbar…
__________________

Turn on/off Vertical Tabs

Am I correct in understanding that your suggestion is to remove the separator between “Bookmarks Toolbar” and “Customize Toolbar…”? We have always included this separator, so I believe we should consult with the context design team before deciding to remove it.

Regarding the ellipses, as far as I know, we only add them if the option leads to multiple choices or opens another window/modal with additional options. I would like to confirm this with Katie as well, so I’ll tag her in this ticket.

Flags: needinfo?(ypopova) → needinfo?(klower)

Also attaching a link to Figma where you can see all context menus on different surfaces.
https://www.figma.com/design/ZFavpnAJee39j2mFf8U3D0/Sidebar-UX-Spec?node-id=17591-233113&t=ESsrnaEv2S1DF5K6-4

Fixed by bug 1948342 I suppose.

Status: NEW → RESOLVED
Closed: 11 days ago
Depends on: 1948342
Flags: needinfo?(klower)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.