1949451 - Closing a horizontal tab stutters towards the end of the animation

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Bastien Orivel [:eijebong]]

As the title says, closing a horizontal tab stutters towards the end, like it lingers around and then suddenly disappear instead of animating properly. It's fairly visible if you close a tab between two other tabs

Mozgression points to:

Bug 1948444 - Fix for vertical tabs min-width r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,sfoster,mconley

Differential Revision: https://phabricator.services.mozilla.com/D238625

This happens on both linux and windows

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1948444

Comment 2

[Mayank Bansal]

See also the perf-alert for TART: https://treeherder.mozilla.org/perfherder/alerts?id=43953&hideDwnToInv=0 (still formally unverified, but backfills confirm the regression is from bug 1948444)

Comment 3

[Kelly Cochrane [:kcochrane]]

Can you please provide a screen recording of the issue?

Comment 4

[Bastien Orivel [:eijebong]]

Attachment: 1949451.mp4

It's not super visible on the video but it is there.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Kelly can you set Severity / Priority? FWIW I think I see it in comment 4 but not very noticeable...

Comment 6

[panicbit]

Attachment: comparison.mp4

Here's a slowed down comparison between 1350 and nightly 2025-02-27 on windows.

Comment 7

[Kelly Cochrane [:kcochrane]]

Bumping this up to P1 per Dao's recommendation.

Comment 8

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1949451 - Fix perf regression for tab close animations

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a748ec54bac
Fix perf regression for tab close animations r=desktop-theme-reviewers,tabbrowser-reviewers,dao

Comment 10

[Serban Stanca [:SerbanS]]

Backed out for causing multiple mochitests failures.

• Backout link

---

• Push with failures - some mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/keyboard/browser_toolbarKeyNav.js | Test timed out -

---

• Push with failures - another mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_tabclose_grow.js | Tabstrip needs to be wide enough to accomodate at least 1 more tab without overflowing. - false == true -

---

• Push with failures - another mochitests failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tabReorder_overflow.js | Test timed out -

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5b7c3108f7f
Fix perf regression for tab close animations r=desktop-theme-reviewers,tabbrowser-reviewers,dao

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a5b7c3108f7f

Comment 13

[Florin Bilt]

(In reply to Cristina Horotan [:chorotan] from comment #12)

https://hg.mozilla.org/mozilla-central/rev/a5b7c3108f7f

Perfherder has detected a talos performance change from push a5b7c3108f7f347575fba86473bcf96f57323811.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
19%	tart	windows11-64-shippable-qr	e10s fission stylo webrender	2.19 -> 1.77
17%	tart	windows11-64-shippable-qr	e10s fission stylo webrender-sw	2.13 -> 1.76
7%	tart	macosx1470-64-shippable	e10s fission stylo webrender-sw	1.98 -> 1.84

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 44177

For more information on performance sheriffing please see our FAQ.