1949548 - Grizzly smoke test is not skipped for tsan

Status: RESOLVED FIXED

(Core :: Fuzzing, defect, P3)

Description

[Jesse Schwartzentruber (:truber)]

Per bug 1933975#c15, the mechanism used to skip the smoke test is wrong.

Comment 1

[Jesse Schwartzentruber (:truber)]

Attachment: Bug 1949548 - Fix fuzzing-python skip condition for tsan r?jmaher!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1933975

Comment 3

[Jesse Schwartzentruber (:truber)]

This skips for local builds, but does not skip in try. I added some debugging prints for the skip_mozinfo fixture in try:

looking for mozconfig in: {'/builds/worker/checkouts/gecko/tools', '/builds/worker/checkouts/gecko', '/builds/worker/checkouts/gecko/tools/fuzzing/smoke', '/builds/worker/checkouts/gecko/tools/fuzzing', '/builds/worker/checkouts'}
skip_mozinfo(tsan) detected
no match with mozinfo: {'os': 'linux', 'processor': 'x86_64', 'version': 'Ubuntu 18.04', 'os_version': StringVersion ('18.04'), 'bits': 64, 'has_sandbox': True, 'display': 'x11', 'automation': True, 'linux_distro': 'Ubuntu', 'apple_silicon': False, 'apple_catalina': False, 'win10_2009': False, 'win11_2009': False, 'is_ubuntu': True, 'arch': 'x86_64'}

So my guess is that target.mozinfo.json is downloaded in /builds/worker/fetches which isn't in the search path for update_mozinfo(). This function is copied all over the place in other tests, so I'm not sure how it works there, but not in this test.

Comment 4

[Frederik Braun [:freddy]]

Triaging at low-severity, as this does not directly affect our users. (We should still fix this of course)

Comment 5

[Jesse Schwartzentruber (:truber)]

Joel, do you know what's wrong with this or how I can debug it? Would other tests be run from the fetches dir instead of the source checkout?

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for the debugging info- the target.mozinfo.json is what you need- it has the right values, but unfortunately it ends up in /builds/worker/fetches/target.mozinfo.json, which isn't the dirs, and it is the wrong filename.

If you could add a hack to:

• rename it from target.mozinfo.json -> mozinfo.json
• add /buids/worker/fetches in the dirs list, ideally the only item in there.

I suspect that will work; If that works for you, we can figure out how to make that integrate smoother.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1933975

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/000d5b76b696
Fix fuzzing-python skip condition for tsan r=jmaher

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/000d5b76b696

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:truber, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.