1949609 - "AboutToCompact" folder notification only sent during autocompaction and only for a single folder, even if multiple compactions are intended.

Status: NEW

(MailNews Core :: General, defect)

Description

[Ben Campbell]

The place in autocompaction which invokes the notification:
https://searchfox.org/comm-central/rev/6c89033d287e8460603f0715e9713831171d1753/mailnews/base/src/nsMsgDBFolder.cpp#1753

It's called upon an arbitrary folder for autocompaction, and not at all for manually-started compactions.

See all references to AboutToCompact:
https://searchfox.org/comm-central/search?q=AboutToCompact&path=&case=false&regexp=false

I suspect the notification isn't even required any more.

Comment 1

[Ben Campbell]

Attachment: Bug 1949609 - Make nsIMsgFolder.notifyCompactCompleted() work for non-local folders. r=#thunderbird-back-end-reviewers

Comment 2

[Phabricator Automation]

Comment on attachment 9467555 [details]
Bug 1949609 - Make nsIMsgFolder.notifyCompactCompleted() work for non-local folders. r=#thunderbird-back-end-reviewers

Revision D239064 was moved to bug 1949605. Setting attachment 9467555 [details] to obsolete.

Comment 3

[Ben Campbell]

Doh. Attached my patch to the wrong bug. So many bugs...