1949660 - [wpt-sync] Sync PR 50857 - Improve <select> GetListItems descendant tracking

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50857 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50857
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Improve <select> GetListItems descendant tracking

This patch improves and consolidates some tree traversal code for
invalidating HTMLSelectElement::GetListItems. \<option>, \<optgroup>,
and \<hr> elements won't be included in any of these traversals if they
are nested inside of an \<option>, an \<hr>, or inside nested \<optgroup>s.

This also improves the OwnerSelectElement performance of
HTMLOptGroupElement and HTMLHRElement by caching the closest select
ancestor on insertion.

Fixed: 396769395
Change-Id: Ib584f2914ee46b0206eebcb93ed9d41f0ae3796b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6279485
Reviewed-by: Traian Captan \<[e-mail]>
Commit-Queue: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1422956}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a665d034b0ea179419f4dc7fd72b12567a22874

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL : 1

Chrome

OK : 1
PASS : 1
FAIL : 1

Safari

OK : 1
FAIL : 1
TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/customizable-select/select-listitems-hr-crash.html [wpt.fyi]: SKIP (Chrome: PASS, Safari: TIMEOUT)
• /html/semantics/forms/the-select-element/customizable-select/option-list.tentative.html [wpt.fyi]
  • select's option list should not include descendants of options, hrs, or nested optgroups.: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /html/semantics/forms/the-select-element/customizable-select/select-listitems-hr-crash.html [wpt.fyi]: SKIP (Chrome: PASS, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/166087cfa3d4
[wpt PR 50857] - Improve <select> GetListItems descendant tracking, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f9d64369ce85
[wpt PR 50857] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/166087cfa3d4
https://hg.mozilla.org/mozilla-central/rev/f9d64369ce85