1949691 - Text-Fragments: Creating text fragment doesn't respect invisible content

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Jan Jaeschke [:jjaschke]]

Example:

• Set dom.text_fragments.create_text_fragment.enabled=true
• Open:
  data: text/html,<p>text with <span style="display:none">display:none</span> content</p>
• Select all (CTRL+A)
• Open context menu, "Copy Link to Highlight¨

Expected:
data: text/html,<p>text with <span style="display:none">display:none</span> content</p>#:~:text=text with content

Actual results:
data: text/html,text with <span style="display:none">display:none</span> content#:~:text=text with display%3Anone content

This happens because nsRange::ToString() is used to get range contents, which ignores display:none, visibility: hidden, et al.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1949691 - Text Fragments: Only use visible content when stringifying ranges. r=emilio!

Using nsRange::ToString() simply concatenates all text nodes (see 0).
However, for creating text fragments only visible text nodes should be considered.
This patch implements a function that only considers visible text nodes
by reusing some utility functions defined in the text fragments spec (1, 2).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d1a9c02d162
Text Fragments: Only use visible content when stringifying ranges. r=emilio

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1d1a9c02d162