1949789 - Frecency is not incremented for viewtime interaction on multiple tabs for the same website on recalculation

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: recalculation vid.mp4

Found in

• Fx 137.0a1

Affected versions

• Fx 137.0a1

Affected platforms

• Windows
• Ubuntu
• macOS

Precondintions
places.frecency.pages.alternative.interactions.viewTimeSeconds set to 10
places.frecency.pages.alternative.interactions.viewTimeIfManyKeypressesSeconds set to 10
places.frecency.pages.alternative.interactions.manyKeypresses set to 5

Steps to reproduce

1. Launch Firefox, navigate to any website and keep it in the foreground for 10 seconds.
2. Open a new tab, navigate to the db query page, "Frecency" section and click the "recalc outdated frecencies" button.
3. Close the tab from step 1.
4. Open a new tab and navigate to the same website as in step 1 and keep it in the foreground for at least 10 seconds.
5. Go back to the db query page and click the "recalc outdated frecencies" button.

Expected result

• Alt Frecency value is increased only after re-calculation.

Actual result

• Alt Frecency value is increased when the website is opened again in step 4.

Regression range

• Not a regression.

Additional notes

• Please note that in the provided video recording the website was already opened 3 times and the bug happened on the 4th calculation.

Comment 1

[James Teow [:jteow]]

Additional Notes mentions the website was already opened 3 previous times.

The interaction creation date and the website visit date are recorded in different processes. We do an approximate match between a visit and an interaction. Right now, the allowable time span difference is 20 minutes.

To reduce the likelihood of pairing an interaction with the wrong visit, we should consider making the allowable default difference much smaller. I honestly think within one minute should be more than sufficient.

Additionally while modifying the base variables, it might also make sense to reduce the max number of Interactions considered in the SQL query to 10 because the max number of samples is currently 10.

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1949789 - Modify default values for alternative frecency - r?mak!

Comment 3

[James Teow [:jteow]]

Attachment: Bug 1949789 - Modify default values for alternative frecency - r?mak!

Original Revision: https://phabricator.services.mozilla.com/D239327

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b59b57f81d58
Modify default values for alternative frecency - r=mak,places-reviewers

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b59b57f81d58

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users who have alternative frecency enabled in an experiment in Fx137 may calculate alternate frecency inaccurately, resulting in slightly inflated scores
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: QA is aware of this bug.
• Risk associated with taking this patch: Low
• Explanation of risk level: This is a pref only change and the feature the pref is tied to is hidden behind a pref.
• String changes made/needed: None.
• Is Android affected?: no

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6469d913b34

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using Fx 138.0a1 nightly on Win 11 and Ubuntu 24. Frecency is correctly incremented on multiple visits.