Closed Bug 1949937 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 50892 - compositing: Move image output and shutdown management out of the compositor

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50892 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50892
Details from upstream follow.

Martin Robinson <mrobinson@igalia.com> wrote:

compositing: Move image output and shutdown management out of the compositor

This is a step toward the renderer-per-WebView goal. It moves various details out of IOCompositor.

  • Image output: This is moved to servoshell as now applications can access the image contents of a WebView via RenderingContext::read_to_image. Most options for this are moved to ServoShellPreferences apart from wait_for_stable_image as this requires a specific kind of coordination in the ScriptThread that is also very expensive. Instead, paint is now simply delayed until a stable image is reached and WebView::paint() returns a boolean. Maybe this can be revisited in the future.
  • Shutdown: Shutdown is now managed by libservo itself. Shutdown state is shared between the compositor and Servo instance. In the future, this sharing might be unecessary.
  • CompositeTarget has been removed entirely. This no longer needs to be passed when creating a Servo instance.

This is an attempt to land #50836 which seems to be wedged.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.