Open Bug 1950062 Opened 21 days ago Updated 11 days ago

Ensure that zucchini patch application crashes do not lead to unexpected issues

Categories

(Toolkit :: Application Update, task)

Product:
Toolkit
Component:
Application Update
Type:
task

Tracking

()

People

(Reporter: yannis, Assigned: yannis)

References

(Blocks 1 open bug)

Details

Part of bug 1632374. Zucchini patch application runs code that has paths that use chromium's CHECK macro. This macro is similar to our MOZ_RELEASE_ASSERT: execution will voluntarily stop at this point if the condition isn't met. It feels like currently, the code for our updater executable was written under the assumption that it should not (voluntarily nor unvoluntarily) crash because I don't see any exception handling there nor voluntarily crashing code paths. So I'm not sure what the consequences of a crash can be. This is something I plan to double check after we have some initial support for zucchini.

:spohl noted that if this is an issue, a potential solution could be to have updater.exe launch a standalone zucchini.exe binary instead of directly integrating zucchini code into updater.exe.

You need to log in before you can comment on or make changes to this bug.