Open Bug 1950137 Opened 25 days ago Updated 25 days ago

Replace search-textbox with moz-input-search

Categories

(Toolkit :: UI Widgets, task, P3)

Product:
Toolkit
Component:
UI Widgets
Type:
task

Tracking

()

People

(Reporter: tgiles, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [recomp])

After we have the moz-input-search component landed in tree and available for use, we should replace the search-textbox.js XUL widget with moz-input-search. By replacing the older XUL widget with the newer HTML component, we can also get closer to fixing Bug 1654502 as moz-input-search will have an accessible user experience for interacting with this component (mainly the "clear search" functionality that was called out in Bug 1655503 Comment #5).

According to this searchfox query, the places we'll need to address are:

  • bookmarksSidebar.xhtml
  • historySidebar.xhtml
  • places.xhtml
  • SiteDataSettings.xhtml
  • sitePermissions.xhtml
  • preferences/main.inc.xhtml
  • preferences/preferences.xhtml

Dealing with the tests may be a bit tricky though. I'm not sure if we want to replace the <search-textbox> in the existing tests, or create new tests that use the moz-input-search instead. Definitely something that will need to be figured out before working on this bug.

You need to log in before you can comment on or make changes to this bug.