1950286 - about:compat page has visual and functional defects

Status: VERIFIED FIXED

(Fenix :: WebExtensions, defect)

Description

[Lorand Janos]

Attachment: Edited_20250225_094009.mp4

Steps to reproduce

1. Open Fenix
2. In a new tab go to about:compat.

Expected behavior

The page loads correctly.

Actual behavior

• While the page loads the 3 displayed tabs should display their content on tap, which doesn't happen;
• Only the last tab triggers the information, the first two tabs do nothing on touch;
• There's an extra line that does not seem to have any visual or functional use until all the information is loaded;
• According to what was discussed for 1945384, the first two tabs should be merged.

Device information

• Firefox version: RC 136.0.
• Android device model: Samsung Galaxy S23 Ultra and Google Pixel 9 Pro XL.
• Android OS version: Android 14 and 15.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Tabs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[William Durand [:willdurand]]

Attachment: Bug 1950286 - Fix #include replacement in the feature-webcompat Android component. r?twisniewski!

Comment 3

[Donal Meehan [:dmeehan]]

Changing Fx137 to unaffected since this is only a bug in Fx136.

Comment 4

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: All users who benefit from the webcompat interventions.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Open about:compat and make sure we see all the information, also verify that there is no error in the browser console for that extension
• Risk associated with taking this patch: low
• Explanation of risk level: This patch fixes a placeholder string (token) to replace it with the content of a file
• String changes made/needed: n/a
• Is Android affected?: yes

Comment 5

[William Durand [:willdurand]]

It's more likely to be a regression from the beta uplift in Bug 1945384.

https://hg.mozilla.org/releases/mozilla-beta/rev/35da3b77f0fd landed on mozilla-beta and contains two sets of changes: the actual fix for Bug 1945384 (topsrcdir) and then another change to the filter function. This second change was a mistake because the token used on mozilla-beta is #include interventions.json, see data/injections.js and data/ua_overrides.js.

That has changed in Fx137, though. In Bug 1945258, the logic was refactored and we now use #include data/interventions.json, see run.js. The gradle file has been updated accordingly, see build.gradle.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/bd4103078c1a

Comment 7

[Lorand Janos]

Verified as fixed on the latest RC 136.0 Build 3.

The page loads correctly with all the info displayed for each tab, switching between them behaves correctly as well.

Devices tested:

• Samsung Galaxy S23 Ultra (Android 14);
• Google Pixel 9 Pro XL (Android 15).

Marking the ticket as verified on 136.