1950378 - Lots of view-transitions reftests time out waiting for a final paint

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Tests get stuck after removing reftest-wait in a loop like:

 0:23.77 pid:378032 1740495241829       Marionette      DEBUG   Force update of layer tree
 0:23.77 pid:378032 1740495241830       Marionette      DEBUG   isMozAfterPaintPending: true
 0:23.80 pid:378032 1740495241862       Marionette      DEBUG   flushRendering ignoreThrottledAnimations:false

Because the animation keeps running ~infinitely. I think after removing reftest-wait we should probably not wait infinitely for a paint?

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1950378 - Don't wait for multiple paints after reftest-wait has been removed. r=jgraham!

If reftest-wait has been removed, it's a strong signal that the
screenshot should be taken. Wait for the next paint, but not more than
that.

This prevents issues with a few view-transition tests that have very
long-running opacity animations, causing timeouts, see
https://hg.mozilla.org/try/rev/ef7d1b85f7c253b38772169a61e61410f0722ef9.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd947e550d42
Don't wait for multiple paints after reftest-wait has been removed. r=jgraham,webdriver-reviewers

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dd947e550d42

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dd947e550d42