1950590 - Audio Output Devices prompt is not automatically focused if there's only 1 speaker

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Gabriel Lee [:gabrielchl]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:135.0) Gecko/20100101 Firefox/135.0

Steps to reproduce:

1. ensure there's only 1 speaker available in your device
2. go to https://jan-ivar.github.io/dummy/gum_picker_output2.html
3. select "other..." in the speakers dropdown (with mouse / keyboard, which triggers selectAudioOutput())

Actual results:

notice that the prompt is shown, but keyboard focus stays in the webpage

Expected results:

focus should be moved to the prompt & stay trapped in the prompt

Comment 1

[Gabriel Lee [:gabrielchl]]

Attachment: single speaker, does not focus correctly

Comment 2

[Gabriel Lee [:gabrielchl]]

Attachment: multiple speakers, focuses correctly

Comment 3

[Gabriel Lee [:gabrielchl]]

it appears that in this patch https://phabricator.services.mozilla.com/D182319 it was made so that it'll tried to focus on the listbox, but in the case of a single there isn't a listbox and therefore focus isn't moved to the prompt

Comment 4

[Gabriel Lee [:gabrielchl]]

Attachment: Bug 1950590 - focus speaker selection button in prompt r?karlt

Focus the first button in the popup if the list is not shown in the prompt.
This happens when there is only 1 speaker.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1478967dca6e
focus speaker selection button in prompt r=karlt,emz

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_fullscreen_permissions_prompt.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/cee76168229efcad37112a53e7765a503a4ae0cf

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/fullscreen/browser_fullscreen_permissions_prompt.js | Test timed out

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fc8c971b606
focus speaker selection button in prompt r=karlt,emz

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4fc8c971b606