1950595 - six in configure.py was removed but configenvironment.py still seems to need six

Status: VERIFIED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

sh js/src/configure --enable-debug-symbols --with-ccache --enable-nspr-build --enable-ctypes --enable-gczeal --enable-rust-simd --disable-tests

Traceback (most recent call last):
  File "/home/USER/trees/mozilla-central/js/src/../../configure.py", line 31, ...ld/backend/configenvironment.py", line 14, in <module>
    import six
ModuleNotFoundError: No module named 'six'

It's late and I'm not sure if this is entirely reproducible, but the configure command seems to run into this error on m-c rev 74fc528d64f4. Running on Python 3.10 on host, Ubuntu Linux 22.04.

I may have a regression range at:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a3d508507022&tochange=5ec13fd9a755

I'm not sure if bug 1948502 is at fault, or whether it's me. :glandium, any ideas?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1948502

Comment 2

[[:anutrix]]

Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)

It seems around line 20:
sys.path.insert(0, os.path.join(base_dir, "third_party", "python", "six"))
I shouldn't have been removed from configure.py till all usages of six are gone.

Can you check if adding above line back there works for you?
I am on Windows and I don't have mozilla-build setup on a linux/WSL environment yet to test your exact sh command.
The ./mach configure and ./mach build showed no errors for me with or without this line so I missed it.
I will make a patch in few mins so that it's ready if needed.

Sry, I missed it. Will try to be more careful next time, not sure if there's a way to test all python files in the project for such import issues. Do let me know if there's such a thing.

Comment 3

[[:anutrix]]

Attachment: WIP: Bug 1950595 - Add back import six regression in configure.py to avoid regressions for now

Comment 4

[[:anutrix]]

Attachment: Bug 1950595 - Add back import six regression in configure.py to avoid regressions for now. r=#build,glandium

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I don't really have a quick easy way to test for now, but I'd say let's add that back in and see how it goes.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24d8e992667b
Add back import six regression in configure.py to avoid regressions for now. r=glandium,firefox-build-system-reviewers

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/24d8e992667b

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I verify that the issue seems to have been fixed.