1950633 - [wpt-sync] Sync PR 50963 - [functions] Use keyframe's tree scope when resolving keyframe values

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50963 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50963
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[functions] Use keyframe's tree scope when resolving keyframe values

CSSInterpolationType calls StyleCascade::Resolve to deal with
substitution functions and other "difficult" values (e.g. revert)
before setting up the interpolation. Since substitution functions
now require tree-scoped lookup (due to \<dashed-function>s), we need
to plumb through the originating tree scope from the @keyframes rule.

The WPT in this CL is missing the usual shadow-crossing tests due
to Issue 41386421, but does at least verify that we propagate the
tree scope. (The tests fail without this CL.)

Bug: 325504770, 394111301
Change-Id: I01edcc6e91c5d78f9f7d8a4d99ddca6dea3fd4a5
Reviewed-on: https://chromium-review.googlesource.com/6298190
WPT-Export-Revision: bf17104db7f7a6a641e5a661a77ef4de6ab5cb73

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a785f5d960ec6f07af2b60e42ac358b653d4639f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
FAIL: 3

Chrome

OK : 1
FAIL: 3

Safari

OK : 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-mixins/function-shadow-animations.html [wpt.fyi]
  • Can animate standard property in shadow: FAIL (Chrome: FAIL, Safari: FAIL)
  • Can animate typed custom property in shadow: FAIL (Chrome: FAIL, Safari: FAIL)
  • Can animate untyped custom property in shadow: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ae9aaf8a310
[wpt PR 50963] - [functions] Use keyframe's tree scope when resolving keyframe values, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3606a5c251c7
[wpt PR 50963] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2ae9aaf8a310
https://hg.mozilla.org/mozilla-central/rev/3606a5c251c7