Closed Bug 1950751 Opened 16 days ago Closed 11 days ago

[wpt-sync] Sync PR 50980 - [PEPC] Fix display of PEPC in quirks mode when height: auto is used

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
138 Branch
Tracking Status
firefox138 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50980 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50980
Details from upstream follow.

Andy Paicu <andypaicu@chromium.org> wrote:

[PEPC] Fix display of PEPC in quirks mode when height: auto is used

In quirks mode when height: auto is used and there is no set height on
any of the elements, the browser will try to set the height to the
entire viewport. However the permission element has special height
restrictions and special interactions between padding and height so this
results in incorrect behavior which can be abused: the element itself
will stay at the predefined max-height, but the child text node will
have a height of 100% and therefore bleed outside the permission
element.

2 root causes: 1) The child does not inherit max-height from the
permission element 2) The handling of the auto + padding case is
intended to allow the padding to basically dictate the overall height as
the result of top-padding + content height + bottom padding. But if
height is auto it makes the content height unnecessarily large (it
should be just the text height an no extra space). So instead if we're
in this case we should treat height: auto as height: fit-content.

Fixed: 398803201
Change-Id: Ie68d58d2658468c2ccca0950d4965d2d19d61afb

Reviewed-on: https://chromium-review.googlesource.com/6304683
WPT-Export-Revision: 90d0f193753d1fd9d26372bf32f68182ad9eebe7

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aedb4b8c25c5 [wpt PR 50980] - [PEPC] Fix display of PEPC in quirks mode when height: auto is used, a=testonly
Status: NEW → RESOLVED
Closed: 11 days ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.