1950782 - UIA Text pattern reports SupportedTextSelection_None on documents

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

If you query the UIA Text pattern's SupportedTextSelection property on a document, it returns SupportedTextSelection_None. This is because we don't expose the SELECTABLE_TEXT state on DocAccessibles in the core tree.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1950782 part 1: Expose the SELECTABLE_TEXT state on DocAccessibles when appropriate.

We already had code to expose SELECTABLE_TEXT in HyperTextAccessible, from which DocAccessible inherits.
However, DocAccessible overrides the method and doesn't call the HyperTextAccessible implementation.
We don't want to do that because it does work that isn't necessary for DocAccessible.
In addition, we need to use a different layout frame for the document.
See the code comments for details.
Specific code has been added to DocAccessible to expose this state.

This fixes the UIA Text pattern's SupportedTextSelection property on documents.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1950782 part 2: Fix UIA SupportedTextSelection on text leaves.

For now, the core SELECTABLE_TEXT state is only exposed on text containers, not on text leaves.
We may want to reconsider this at some point.
For now, just handle this case in the UIA code, since that's the only place it matters.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb94368d2970
part 1: Expose the SELECTABLE_TEXT state on DocAccessibles when appropriate. r=nlapre
https://hg.mozilla.org/integration/autoland/rev/1c9ee07f74ec
part 2: Fix UIA SupportedTextSelection on text leaves. r=nlapre

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_accessibility_print_to_json.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/2993c64682bd621e8a0479c1176561bf3a1bd523

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1c9ee07f74ec716850a0e6039c061cf2282cb4bb&selectedTaskRun=FRE_y-aNRkKGLobdr0Ot5A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=497386518&repo=autoland&lineNumber=2695

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e71f3c882012
part 1: Expose the SELECTABLE_TEXT state on DocAccessibles when appropriate. r=nlapre,devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/9916a6e16cf0
part 2: Fix UIA SupportedTextSelection on text leaves. r=nlapre

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e71f3c882012
https://hg.mozilla.org/mozilla-central/rev/9916a6e16cf0