1950988 - False contrast problem positives when using `oklch()` in Storybook's a11y check

Status: NEW

(Toolkit :: UI Widgets, defect)

Description

[Jules Simplicio [:jules]]

Can be a bit outside our control but today Storybook throws false positives of contrast issues when using oklch().
Ran into this while implementing 1861526. Didn't find any answers from doing some quick research. But ran this by :mstriemer too.
I reckon we can file a bug with Storybook themselves? But filing here just to be safe.

Comment 1

[Tim Giles [:tgiles]]

This appears to be an issue with our package-lock.json for our Storybook. Even with our current version of Storybook and the accessibility addon, we should be installing a later version of axe-core that supports the CSS4 color spaces (including oklch()). Right now our installed axe-core version is 4.6.2 and we need at least 4.7.1 for the additional color space support. If we delete the current package-lock.json and run npm i, then the installed axe-core version will be 4.10.2. We should delete the old package-lock and add a new one to fix this issue.

Comment 2

[Mark Striemer [:mstriemer]]

It would be nice to have a mach command to update our storybook dependencies. Rather than doing this manually we can add a ./mach storybook upgrade command that will rm the package-lock.json and node_modules then run npm install to update all of our dependencies.