1950991 - Serialize access to sessionsPendingDeletion

Status: VERIFIED FIXED

(Firefox for Android :: Browser Engine, defect)

Description

[Jeff Boek [:boek]]

https://mozilla.sentry.io/issues/6334690550/?project=6295551&project=6375561&query=is%3Aunresolved%20level%3Afatal%20firstSeen%3A-1w&referrer=issue-stream&sort=freq&statsPeriod=14d&stream_index=0

We believe that this may be a regression caused by Bug 1892751 but the stack trace isn't very clear.

Comment 1

[Jeff Boek [:boek]]

Attachment: Bug 1950991 - Serializes access to sessionsPendingDeletion

Comment 2

[Chris Peterson [:cpeterson]]

Does this crash only affect users with SHIP enabled? I suspect all users are potentially affected because this crash is one of our top crashes in Beta 136, where SHIP is not enabled. We should consider uplifting this fix to Beta 137 or even a 136.x dot release if we see these crashes in Release.

Comment 3

[Jeff Boek [:boek]]

Assigned reviewers and posted in the broader chat channel to see if we can get a review for this patch

Comment 4

[Donal Meehan [:dmeehan]]

Tracking since the volume is higher in 136 than 135.
We should include this in next week's planned Android release for Fx136.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c96eda77c820
Serializes access to sessionsPendingDeletion r=android-reviewers,kaya

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c96eda77c820

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:boek, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Donal Meehan [:dmeehan]]

Adding to Comment 7, please add a release uplift request also.
It will have coverage in nightly and beta before we go to release.

Comment 9

[Jeff Boek [:boek]]

Attachment: Bug 1950991 - Serializes access to sessionsPendingDeletion

Original Revision: https://phabricator.services.mozilla.com/D239962

Comment 10

[Jeff Boek [:boek]]

Attachment: Bug 1950991 - Serializes access to sessionsPendingDeletion

Original Revision: https://phabricator.services.mozilla.com/D239962

Comment 11

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Users will experience this crash in 136
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Delete tabs using the tabs tray
• Risk associated with taking this patch: Low
• Explanation of risk level: Adds a mutex, but code is easy to understand. May be close to medium as it has not had time to bake in Nightly or Beta
• String changes made/needed: none
• Is Android affected?: yes

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users will experience this crash in 137
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Delete tabs using the tabs tray after browsing.
• Risk associated with taking this patch: Low
• Explanation of risk level: Adds a mutex, but code is easy to understand. May be close to medium as it has not had time to bake in Nightly or Beta
• String changes made/needed: None
• Is Android affected?: yes

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b4e722291642

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/6944b9b7041b

Comment 15

[Vasilica Tamas QA [:vtamas]]

This issue is verified as fixed on Firefox Nightly 138 (2025-03-10), Firefox 137 Beta 4 and Firefox RC 136.0.1 under Samsung S24 Ultra (Android 14) and Google Pixel 8 (Android 15). No crash was encountered when closing tabs from tabs tray.