Closed Bug 1951031 Opened 20 days ago Closed 16 days ago

[wpt-sync] Sync PR 51010 - [SAA] Remove unnecessary recursive WPT embedding; ignore irrelevant events

Categories

(Core :: Privacy: Anti-Tracking, task, P4)

task

Tracking

()

RESOLVED FIXED
138 Branch
Tracking Status
firefox138 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51010 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51010
Details from upstream follow.

Chris Fredrickson <cfredric@chromium.org> wrote:

[SAA] Remove unnecessary recursive WPT embedding; ignore irrelevant events

This test used to recursively embed an iframe of itself, which is
unnecessary (and sometimes causes problems). Additionally, some of the
event listeners didn't properly ignore irrelevant events (which is the
cause of the occasional 'expected (string) "granted" but got (object)
object "[object Object]"' errors on
https://wpt.fyi/results/storage-access-api/storage-access-permission.sub.https.window.html?label=master&label=experimental&aligned&view=interop.

Change-Id: I634fed3977058707363abbeb393eb7b58a7079fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6309927
Reviewed-by: Sandor «Alex» Major \<sandormajor@chromium.org>
Auto-Submit: Chris Fredrickson \<cfredric@chromium.org>
Commit-Queue: Sandor «Alex» Major \<sandormajor@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1426117}

Component: web-platform-tests → Privacy: Anti-Tracking
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
PASS : 7

Chrome

TIMEOUT: 2
NOTRUN : 2

Safari

TIMEOUT: 2
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /storage-access-api/storage-access-permission.sub.https.window.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: TIMEOUT, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

  • /storage-access-api/storage-access-permission.sub.https.window.html [wpt.fyi]: OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub], SKIP [Gecko-linux1804-64-qr-debug] (Chrome: TIMEOUT, Safari: TIMEOUT)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4b7af878725 [wpt PR 51010] - [SAA] Remove unnecessary recursive WPT embedding; ignore irrelevant events, a=testonly
Status: NEW → RESOLVED
Closed: 16 days ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.