195108 - Add accesskeys to editor Find and Replace dialog (editor)

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[piers]

Add accesskeys to editor Find and Replace dialog

Comment 1

[sairuh (rarely reading bugmail)]

this is the dlg in Composer, right?

Comment 2

[piers]

Attachment: Add accesskeys

Also adjust wording to better match the navigator find dialog.

Comment 3

[piers]

Its for Editor (i.e. used in composer and mail (message compose))

Comment 4

[Kathleen :Brade]

Comment on attachment 115671 [details] [diff] [review]
Add accesskeys

module owner permission granted:  mo=brade

Comment 5

[:deanis74]

Comment on attachment 115671 [details] [diff] [review]
Add accesskeys

>-<!ENTITY replaceAndFindButton.label "Replace and Find">
>+<!ENTITY replaceAndFindButton.label "Find and Replace">

Looks good, except I'm questioning this.  brade, you're OK with this change? 
r=me if she's ok with it.

Comment 6

[Kathleen :Brade]

Dean--good catch...
That button should not be renamed since you have to replace before you find the
next occurrence.

Comment 7

[piers]

Attachment: Add accesskeys v2

Doesn't that button just confuse things? Anyhow, this patch leaves it alone.

Comment 8

[:deanis74]

Comment on attachment 115681 [details] [diff] [review]
Add accesskeys v2

>-<!ENTITY findField.label "Find what:">
>+<!ENTITY findField.label "Find text:">

Personally I think "Find what" is right and it's wrong in browser, based on the
standard Windows Find dialog, but at least we'll be consistent this way.  r=me

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 115681 [details] [diff] [review]
Add accesskeys v2

sr=dmose

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/EdReplace.xul;
/cvsroot/mozilla/editor/ui/dialogs/content/EdReplace.xul,v  <--  EdReplace.xul
new revision: 1.7; previous revision: 1.6
done
Checking in locale/en-US/EditorReplace.dtd;
/cvsroot/mozilla/editor/ui/dialogs/locale/en-US/EditorReplace.dtd,v  <-- 
EditorReplace.dtd
new revision: 1.3; previous revision: 1.2
done

Comment 11

[sairuh (rarely reading bugmail)]

vrfy'd fixed on win2k and linux rh8.0, 2003.03.03.05.