Add accesskeys to editor Find and Replace dialog (editor)

VERIFIED FIXED

Status

()

Core
Keyboard: Navigation
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: piers, Assigned: piers)

Tracking

({access})

Trunk
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.61 KB, patch
Dean Tessman
: review+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
Add accesskeys to editor Find and Replace dialog
this is the dlg in Composer, right?
(Assignee)

Comment 2

16 years ago
Created attachment 115671 [details] [diff] [review]
Add accesskeys

Also adjust wording to better match the navigator find dialog.
(Assignee)

Comment 3

16 years ago
Its for Editor (i.e. used in composer and mail (message compose))
(Assignee)

Updated

16 years ago
Attachment #115671 - Flags: review?(dean_tessman)
Summary: Add accesskeys to editor Find and Replace dialog → Add accesskeys to editor Find and Replace dialog (editor)

Comment 4

16 years ago
Comment on attachment 115671 [details] [diff] [review]
Add accesskeys

module owner permission granted:  mo=brade

Comment 5

16 years ago
Comment on attachment 115671 [details] [diff] [review]
Add accesskeys

>-<!ENTITY replaceAndFindButton.label "Replace and Find">
>+<!ENTITY replaceAndFindButton.label "Find and Replace">

Looks good, except I'm questioning this.  brade, you're OK with this change? 
r=me if she's ok with it.

Comment 6

16 years ago
Dean--good catch...
That button should not be renamed since you have to replace before you find the
next occurrence.
(Assignee)

Comment 7

16 years ago
Created attachment 115681 [details] [diff] [review]
Add accesskeys v2

Doesn't that button just confuse things? Anyhow, this patch leaves it alone.
Attachment #115671 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #115681 - Flags: review?(dean_tessman)
(Assignee)

Updated

16 years ago
Attachment #115671 - Flags: review?(dean_tessman)

Comment 8

16 years ago
Comment on attachment 115681 [details] [diff] [review]
Add accesskeys v2

>-<!ENTITY findField.label "Find what:">
>+<!ENTITY findField.label "Find text:">

Personally I think "Find what" is right and it's wrong in browser, based on the
standard Windows Find dialog, but at least we'll be consistent this way.  r=me
Attachment #115681 - Flags: review?(dean_tessman) → review+
(Assignee)

Updated

16 years ago
Attachment #115681 - Flags: superreview?(dmose)

Comment 9

16 years ago
Comment on attachment 115681 [details] [diff] [review]
Add accesskeys v2

sr=dmose
Attachment #115681 - Flags: superreview?(dmose) → superreview+
Checking in content/EdReplace.xul;
/cvsroot/mozilla/editor/ui/dialogs/content/EdReplace.xul,v  <--  EdReplace.xul
new revision: 1.7; previous revision: 1.6
done
Checking in locale/en-US/EditorReplace.dtd;
/cvsroot/mozilla/editor/ui/dialogs/locale/en-US/EditorReplace.dtd,v  <-- 
EditorReplace.dtd
new revision: 1.3; previous revision: 1.2
done
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
vrfy'd fixed on win2k and linux rh8.0, 2003.03.03.05.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.