1951101 - Handling of MOZ_LANGPACK_CONTRIBUTORS in defines.inc files should be less custom

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Eemeli Aro [:eemeli]]

By now, Seamonkey is the only place where we still have this oddity in suite/locale/en-US/defines.inc and suite/extensions/irc/locale/en-US/defines.inc:

# If non-English locales wish to credit multiple contributors, uncomment this
# variable definition and use the format specified.
# #define MOZ_LANGPACK_CONTRIBUTORS <em:contributor>Joe Solon</em:contributor> <em:contributor>Suzy Solon</em:contributor>

This is requiring additional care in Pontoon, as it's the only place where we have a commented source message being used as an actual message.

Given how these files are handled in langpack_manifest.py and preprocessor.py, an empty value here would be handled exactly the same as a commented-out value

Therefore, could the contents of the en-US source be updated to something like the following? Doing so would not invalidate any translations, but it would allow us to drop the customization needed in Pontoon for this one message.

# A space-separated list of contributors, each wrapped in an <em:contributor> element. Can be left empty.
# Example: <em:contributor>Joe Solon</em:contributor> <em:contributor>Suzy Solon</em:contributor>
#define MOZ_LANGPACK_CONTRIBUTORS

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1951101-l10ncontrib-25321.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: --
Testing completed (on m-c, etc.): 2.53.21b1 pre
Risk to taking this patch (and alternatives if risky): low risk
String changes made by this patch: some unused cZ entries removed.

Notes:
For en-US the string is not used. If the tag is missing in a language it will be reported for the merge but we can just push a default empty string to the l10n repo so I just removed all the special preprocessing.

cZ no longer has its own language pack so the irc defines.inc can be removed.

Comment 2

[Ian Neal]

Comment on attachment 9469287 [details] [diff] [review]
1951101-l10ncontrib-25321.patch

[Triage Comment]
We will need to compare the ChatZilla defines.inc against locale.authors in chatzilla.properties, I will work on that.

Comment 3

[Ian Neal]

(In reply to Ian Neal from comment #2)

Comment on attachment 9469287 [details] [diff] [review]
1951101-l10ncontrib-25321.patch

[Triage Comment]
We will need to compare the ChatZilla defines.inc against locale.authors in chatzilla.properties, I will work on that.

Done that.

Comment 4

[Frank-Rainer Grahl (:frg)]

Bug 1948783 already removed some of the code. I just forgot to update comm-l10n central

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1951101-l10ncontrib-25321.patch

Rebased comm-central part. r+ from IanN retained.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7baa96cc8685
Properly define language pack contributors and remove obsolete l10n cZ entries. r=IanN DONTBUILD

Comment 7

[Eemeli Aro [:eemeli]]

Thank you, this is even better than I hoped! With this, we're really close to being able to retire support for .inc entirely as a localization file format. I'll file a separate bug for the one remaining SeaMonkey use of it.