1951401 - [wpt-sync] Sync PR 51048 - Make sibling-index()/sibling-count() use flat tree

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 51048 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51048
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Make sibling-index()/sibling-count() use flat tree

Introduce a mode for counting assigned slot siblings for host children
instead of their light tree sibling order. The :nth-*() selectors
still consider the light tree.

We cache the light-tree index for non-host children to be able to share
as much as possible of cached indices between the :nth-*() selectors and
the sibling-index() values.

Bug: 40282719

Change-Id: If1381471bea3498835df76fdc826162667bf8017
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6304506
Reviewed-by: Steinar H Gunderson \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1427060}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6dbe1414b8e1f8e52e545fefb1e354456de199b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-values/calc-sibling-function-in-shadow-dom.html [wpt.fyi]
  • Host children have sibling-index() and sibling-count() based on assignedNodes order: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d4c4eeb0816
[wpt PR 51048] - Make sibling-index()/sibling-count() use flat tree, a=testonly
https://hg.mozilla.org/integration/autoland/rev/bfa32310be1c
[wpt PR 51048] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/3d4c4eeb0816
https://hg.mozilla.org/mozilla-central/rev/bfa32310be1c