Closed Bug 1951438 Opened 20 days ago Closed 12 days ago

[wpt-sync] Sync PR 51051 - webrtc wpt: assert that getStats does not throw on a closed peerconnection

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51051 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51051
Details from upstream follow.

Philipp Hancke <philipp.hancke@googlemail.com> wrote:

webrtc wpt: assert that getStats does not throw on a closed peerconnection

see https://github.com/w3c/webrtc-pc/issues/131

Drive-by: disable WPT for "url" in stats, this is not testable in WPT

BUG=webrtc:42222542

Change-Id: Id5205993c82e9b0b88316d3d1e6e40d341e9b765
Reviewed-on: https://chromium-review.googlesource.com/6313874
WPT-Export-Revision: 51505cea86aa0ab853cf11a58c3c6a9d90d63cd8

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 73 subtests

Status Summary

Firefox

OK : 2
PASS: 75
FAIL: 15

Chrome

OK : 2
PASS: 90

Safari

OK : 2
PASS: 84
FAIL: 6

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /webrtc/RTCPeerConnection-getStats.https.html [wpt.fyi]
    • getStats succeeds on a closed peerconnection: FAIL (Chrome: PASS, Safari: PASS)
  • /webrtc/RTCPeerConnection-mandatory-getStats.https.html [wpt.fyi]
    • RTCRtpStreamStats's transportId: FAIL (Chrome: PASS, Safari: PASS)
    • RTCAudioSourceStats's totalAudioEnergy: FAIL (Chrome: PASS, Safari: PASS)
    • RTCAudioSourceStats's totalSamplesDuration: FAIL (Chrome: PASS, Safari: PASS)
    • RTCTransportStats's bytesSent: FAIL (Chrome: PASS, Safari: PASS)
    • RTCTransportStats's bytesReceived: FAIL (Chrome: PASS, Safari: PASS)
    • RTCTransportStats's selectedCandidatePairId: FAIL (Chrome: PASS, Safari: PASS)
    • RTCTransportStats's localCertificateId: FAIL (Chrome: PASS, Safari: PASS)
    • RTCTransportStats's remoteCertificateId: FAIL (Chrome: PASS, Safari: PASS)
    • RTCIceCandidatePairStats's totalRoundTripTime: FAIL (Chrome: PASS, Safari: PASS)
    • RTCIceCandidatePairStats's responsesReceived: FAIL (Chrome: PASS, Safari: PASS)
    • RTCIceCandidatePairStats's currentRoundTripTime: FAIL (Chrome: PASS, Safari: PASS)
    • RTCCertificateStats's fingerprint: FAIL (Chrome: PASS, Safari: PASS)
    • RTCCertificateStats's fingerprintAlgorithm: FAIL (Chrome: PASS, Safari: PASS)
    • RTCCertificateStats's base64Certificate: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b83891c79e72 [wpt PR 51051] - webrtc wpt: assert that getStats does not throw on a closed peerconnection, a=testonly https://hg.mozilla.org/integration/autoland/rev/a6585d11e9aa [wpt PR 51051] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b83891c79e72
https://hg.mozilla.org/mozilla-central/rev/a6585d11e9aa

Status: NEW → RESOLVED
Closed: 12 days ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.