1951510 - Follow up cleanup for Onboarding strings that were marked for removal in v135

Status: RESOLVED FIXED

(Fenix :: Onboarding, task)

Description

[[:harrisono]]

The following strings were marked for removal in 135 but were not fully removed from all usage points in time for the Beta cut for 137.

The strings have been re-marked for removal in 137 for now but should be removed before the end of this cycle and uplifted if possible.

Strings following:

studies_restart_app
Used in Fenix here: https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/studies/StudiesAdapter.kt#143
Used in Focus here: https://searchfox.org/mozilla-central/source/mobile/android/focus-android/app/src/main/java/org/mozilla/focus/settings/privacy/studies/StudiesViewHolder.kt#57

onboarding_customize_toolbar_skip_button
Used in fenix here: https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/onboarding.fml.yaml#148

onboarding_customize_theme_skip_button
Used in fenix here: https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/onboarding.fml.yaml#127

studies_restart_dialog_ok
Used in fenix here: https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/studies/StudiesAdapter.kt#132

studies_restart_dialog_cancel
Used in Fenix here: https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/settings/studies/StudiesAdapter.kt#138

Comment 1

[[:harrisono]]

Phabricator PR with strings marked for later removal:
https://phabricator.services.mozilla.com/D240211

Comment 2

[[:harrisono]]

Previous phabricator PR that removed partially some of the strings but not all usages.

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 1951510 - Part 1: Remove app restarting alert on experiment deletion

The restart requirement was removed by nimbus, and this is a follow up to bug 1935174, removing leftovers from both Fenix and Focus.

Comment 4

[Mike a [:mavduevskiy]]

Attachment: Bug 1951510 - Part 2: Remove unused strings and uncomment nimbus onboarding defaults

A follow up to bug 1951464.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32cf09898b85
Part 1: Remove app restarting alert on experiment deletion r=android-reviewers,android-l10n-reviewers,delphine,gmalekpour,twhite
https://hg.mozilla.org/integration/autoland/rev/3f609a7de2e7
Part 2: Remove unused strings and uncomment nimbus onboarding defaults r=android-reviewers,android-l10n-reviewers,delphine,gmalekpour,twhite

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/32cf09898b85
https://hg.mozilla.org/mozilla-central/rev/3f609a7de2e7