1951602 - 7.72% perf_reftest_singletons tiny-traversal-singleton.html (Linux) regression on Wed January 22 2025

Status: RESOLVED WONTFIX

(Core :: Networking, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

Perfherder has detected a talos performance regression from push 176f6d1d5c2367b138a91e8315b72c5af0cb0cbf. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
8%	perf_reftest_singletons tiny-traversal-singleton.html	linux1804-64-shippable-qr	e10s fission stylo webrender	932.16 -> 1,004.17

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 43457

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to [e-mail].

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:leplatrem, since you are the author of the regressor, bug 1786310, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1786310

Comment 3

[Donal Meehan [:dmeehan]]

There is a pending NI for the last week, so this likely won't make Fx136.
:edgul pinging as triage owner if this has the correct severity/priority?
Should we expect an investigation in time for Fx138?

Comment 4

[edgul]

Forwarding NI to valentin

Comment 5

[:Gijs (he/him)]

https://firefox-source-docs.mozilla.org/testing/perfdocs/talos.html#perf-reftest-singletons says "ask Emilio or the layout team" so...

off-hand this makes no sense to me. I'd expect stylo tests to be completely independent from this removal.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

If you look at the graph it was probably a spike, and it seems back to where it was... So I agree it's unlikely to be the culprit...

If numbers are back to where they were, I suggest wontfixing this?

Comment 7

[Mathieu Leplatre [:leplatrem]]

Thank you for looking at this thoroughly. Marking as wontfix

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Thanks Emilio!