1951790 - Optimize baseline profiler and debugger checks more

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Ryan Hunt [:rhunt]]

We have two checks in the baseline compiler loop for if debugging is enabled and for if the profiler is enabled. These are both very uncommon and could be folded into a single check to minimize the overhead here.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1951790 - wasm: Fold debugger and profiler checks into a single comparison. r?jseward

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c1df835910b
wasm: Fold debugger and profiler checks into a single comparison. r=jseward

Comment 3

[Atila Butkovits]

Backed out for causing bustages at WasmBaselineCompile.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/684b2db4837ae04c9d40f19f5fdb3aed873a4c2f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6c1df835910b17d420c4be2f380a0480383a203e

Failure log: https://treeherder.mozilla.org/logviewer?job_id=499093927&repo=autoland&lineNumber=35744

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b9aec7359d6
wasm: Fold debugger and profiler checks into a single comparison. r=jseward

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0b9aec7359d6