1952028 - [wpt-sync] Sync PR 51137 - Resolve colors where possible when creating an animation effect

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 51137 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51137
Details from upstream follow.

Kevin Babbitt <[e-mail]> wrote:

Resolve colors where possible when creating an animation effect

CSS color-mix and relative colors should not be resolved until used-
value time. We have the code to implement that behavior, controlled by
flag CSSRelativeColorLateResolveAlways. However, enabling that flag
caused issues with animation of relative colors, since the animation
code was expecting the previous behavior of resolving at parse time.

The fix is to resolve these values in color animation setup where
possible. Cases such as a color-mix using currentcolor are not
handled; animating such values will require more complex interpolation
logic to account for the fact that currentcolor may itself change over
the course of an animation.

This CL also re-enables the CSSRelativeColorLateResolveAlways flag since
the issue that caused it to be disabled should now be fixed.

Bug: 390847913
Change-Id: I4b728b3ce44097d0e6960426408b63570c706031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6300056
Commit-Queue: Kevin Babbitt \<[e-mail]>
Reviewed-by: Kevin Ellis \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1428446}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b43066c2eb44ad3a034728d56541927eb5137d83

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
PASS: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-animations/animate-with-relative-color.html [wpt.fyi]
  • Animate from absolute oklch to relative oklch: FAIL (Chrome: FAIL, Safari: PASS)
  • Animate from color keyword to relative rgb: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c191974cae54
[wpt PR 51137] - Resolve colors where possible when creating an animation effect, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c1c4054e3af2
[wpt PR 51137] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c191974cae54
https://hg.mozilla.org/mozilla-central/rev/c1c4054e3af2