Closed
Bug 1952099
Opened 21 days ago
Closed 16 days ago
Ensure Figma export script checks "platform" for light/dark values when "brand" is incomplete
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
138 Branch
| Tracking | Status | |
|---|---|---|
| firefox138 | --- | fixed |
People
(Reporter: julianwels, Assigned: julianwels)
Details
Attachments
(1 file)
The Figma export script for design tokens currently prioritizes values from the "brand" key when resolving light and dark mode colors. If "brand" contains the values for light and dark, they are correctly used. However, when "brand" is present but only defines "forcedColors" (without specifying light/dark values), the script does not check the "platform" key for these values instead. This results in missing or incorrect color values in the exported Figma tokens.
|
Assignee | |
Updated•21 days ago
|
Assignee: nobody → julianwels
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•21 days ago
|
||
Pushed by hjones@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3fcf2ed2efda
Fix missing color values in Figma token export when both brand and platform are defined. r=reusable-components-reviewers,desktop-theme-reviewers,hjones DONTBUILD
|
||
Comment 3•16 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 16 days ago
status-firefox138:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•