1952416 - Downloads context menu has an extra divider and options are jumbled

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Blake]

Attachment: download.png

Steps to reproduce:

Right click the download menu

Actual results:

Context menu has divider on the top row

Comment 1

[Blake]

Similar to Bug 1946834 and Bug 1948342

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:nsharpley, since you are the author of the regressor, bug 1948342, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[:Gijs (he/him)]

The options are also in the wrong order. Previously the order was:

• pin item to overflow menu
• hide button when empty
• remove from toolbar

---

• show panel when download begins

---

• remaining customization options

AFAICT this is just because bug 1948342 moved the toolbar controls down in the physical menu structure (below tab and extension items) but left the downloads item at the top. In theory fixing that should be straightforward.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1948342

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1952416 - fix downloads button context menu ordering to be correct again, r?nsharpley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27372295f4bc
fix downloads button context menu ordering to be correct again, r=nsharpley

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/27372295f4bc

Comment 8

[:Gijs (he/him)]

Attachment: Bug 1952416 - fix downloads button context menu ordering to be correct again, r?nsharpley

Original Revision: https://phabricator.services.mozilla.com/D241109

Comment 9

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: confusing menu with some ordering/visual issues
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: see comment 0 / comment 3
• Risk associated with taking this patch: low
• Explanation of risk level: just moving 2 HTML bits back to where they should be, has automated test
• String changes made/needed: no
• Is Android affected?: no

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8db0d815fc31

Comment 11

[Ciprian Georgiu, Desktop QA]

I've reproduced the issues described in comment 0 and comment 3, using Beta 137.0b4 under Win 11.

The issue is verified as fixed on latest Nightly 138.0a1 and Beta 137.0b6 (treeherder build) running Win 11, macOS 14 and Ubuntu 24.04.