1952541 - Use POST requests when communicating with Phabricator

Status: RESOLVED FIXED

(Conduit :: Lando, defect)

Description

[Jon Buckley [:jbuck]]

While setting up the new WAF, we discovered that Lando was using GET requests with a body, and the WAF blocks these as an error: https://www.fastly.com/documentation/guides/concepts/errors/#get-and-head-requests-with-body

:zeid and I did some testing with POST requests and it appears to work the same as GET requests. So I'd like to try switching Lando to use POST requests with Phabricator, so that we can use the new WAF.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] phabricator: use post instead of get in api calls (bug 1952541) (#233)

Comment 2

[BMO Github Automation]

Attachment: [mozilla-conduit/lando-api] phabricator: use POST method to be HTTP spec-compliant (Bug 1952541) (#460)

Comment 3

[Jon Buckley [:jbuck]]

We've confirmed that these two PRs for lando legacy and lando modern work the same with phabricator, and the WAF allows requests through again.