1952825 - Sidebar pressed state shows no focus indication

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Description

[:Gijs (he/him)]

Found on macOS but may well be present elsewhere.

1. current nightly, clean profile.
2. open settings
3. enable the new sidebar (search for sidebar, tick "Show sidebar"). The sidebar button appears on the top left of the window next to the back/fwd buttons
4. accel-L to focus the address bar (expands the address bar)
5. shift-tab to focus the address/search input thingummywhatsit (shows blue focus box around it)
6. shift-tab again to focus the sidebar button

ER:
can see blue focus box around sidebar button

AR:
no blue focus box

Comment 1

[Alice0775 White]

I can reproduce the issue on Nightly138.0a1 Windows11 and ubuntu24.04.

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]: UX regression

This bug occurs when the toolbutton is in the active state.
This is not limited to revamp.sidebar but also legacy sidebar toolbar button.

STR:

1. Put the “Sidebars” toolbutton on the Nav bar right next to the urlbar
2. Open sidebar(Ctrl+B) so that the toolbutton will be in active state.
3. Press Ctrl+L then [tab] key so that the toolbutton gets focus.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1015843c71ed475633fef84a8d1b707dce090c30&tochange=e46eaccd15b497f7694c9f16e80815d380f2e96b

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:mstriemer, since you are the author of the regressor, bug 1881851, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1952825 - Don't change toolbarbutton outline for interactive states when focused r?#desktop-theme-reviewers

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox137 (beta). However, the bug still has low severity.

:cbellini, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c443a9b58b5d
Don't change toolbarbutton outline for interactive states when focused r=desktop-theme-reviewers,dao

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/c443a9b58b5d

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mstriemer, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox137 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Mark Striemer [:mstriemer]]

Comment on attachment 9470909 [details]
Bug 1952825 - Don't change toolbarbutton outline for interactive states when focused r?#desktop-theme-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Focus location can get lost when the sidebar is expanded as no focus indication is shown
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS refactor
• String changes made/needed: No
• Is Android affected?: No

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8146351ddd52