[junk] Add a "?" button to the envelope that brings up the junk intro dialog

VERIFIED FIXED in mozilla1.4alpha


MailNews: Message Display
15 years ago
14 years ago


(Reporter: esther, Assigned: (not reading, please use seth@sspitzer.org instead))



Firefox Tracking Flags

(Not tracked)


(Whiteboard: [adt1])


(5 attachments, 1 obsolete attachment)



15 years ago

Comment 1

15 years ago
Spec change, need descriptive dialog for Junk Mail Controls to be launched when
user does a first time action of:
*hit the Junk Button on the toolbar
*hit the junk column to flag a messages as Junk/Not Junk
*click on any one of the Junk menu items under Tools

This descriptive dialog should pop up only the first time any of these actions
are exercised, after it's dismissed exercising the above item will perform the
action specified for each.  Note, this dialog will lannch anytime the user
clicks on the ? button in the envelop on junk messages.
Keywords: nsbeta1+
Whiteboard: [adt1]

Comment 2

15 years ago
Created attachment 115793 [details]
desctiptive dialog

Comment 3

15 years ago
also note it was decided to include a help button on the informative popup that
takes you to the online help (same place that" Tools | Junk Controls | Help"
takes you).


15 years ago
Summary: [junk] - spec change need descriptive dialog for junk mai control → [junk] - spec change need descriptive dialog for junk mail control

Comment 4

15 years ago

Comment 5

15 years ago
sorry, reassigning again
Assignee: mscott → sspitzer

Comment 6

15 years ago
Note in the descriptive dialog attached we need to remove the statement "Would
you like to enable Junk Mail Controls now?" from the description and have:
Junk Mail Controls ON by default
Junk Mail column ON by default and displayed.
Target Milestone: --- → mozilla1.4alpha
Summary: [junk] - spec change need descriptive dialog for junk mail control → [junk] Add a help button to the envelope that brings up the junk intro dialog
Created attachment 117416 [details] [diff] [review]
fix, includes patch for bug #197255 (unused xul / dtd removal)
Created attachment 117417 [details]
screen shot

note, the wording isn't 100% correct yet, I'll ping robinf / jglick for some
better wording.
fixed, r/sr=bienvenu
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 11

15 years ago
I think the Help button in the envelope should point to the "Controlling Junk
Mail" section of help.

Context ID info for the Help button: 
<rdf:li> <rdf:Description ID="mail-junk" nc:name="Controlling Junk Mail"
nc:link="chrome://help/locale/mail_help.html#JUNK_MAIL" /> </rdf:li>

The Help button in the junk intro dialog should also point to this location.

Comment 12

15 years ago
Suggested text for dialog:

"Mail automatically detects incoming messages that appear to be junk mail (also
known as spam). Messages that Mail thinks are junk will display a junk icon
<picture of icon>.

At first, you must train Mail to identify junk mail by using the Junk toolbar
button to mark messages as junk or not junk.
Once Mail is correctly identifying junk mail, you can use the Junk Mail Controls
to automatically move incoming junk mail to the Junk folder.

For more information, click Help."
Created attachment 117928 [details]
classic skin screen shot, per robinf / jglick comments
Attachment #117417 - Attachment is obsolete: true
Created attachment 117929 [details] [diff] [review]
supplimental fix, per robinf / jglick
I've landed the supplimental fix.

1)  modern skin thread pane icon for junk is now centered
2)  button is "?" instead of help
3)  info dialog doesn't close when you hit help
4)  help goes to mail-junk section of help
5)  wording changed per robinf.
Component: Mail Back End → Mail Window Front End
Summary: [junk] Add a help button to the envelope that brings up the junk intro dialog → [junk] Add a "?" button to the envelope that brings up the junk intro dialog

Comment 16

15 years ago
This looks great. One small nit - can you change the dialog title to "About Junk

Comment 17

15 years ago
Also -- please add a period at the end of the sentence that begins "Once Mail is
correctly identifying junk mail...". Thanks.
I've fixed robin's two issues.

Comment 19

15 years ago
Created attachment 118034 [details]

Looks great Seth. 
Another small nit, can you reduce the size of the "?" button so it takes up
less space? Thanks. :-)
whoops, I accidentally checked in something from neil to mailWindowOverlay.js, 
under this bug number.  I've backed it out.
esther had a good suggestion.

a button with "?" looks almost like a bug.

what about an icon button instead?

Comment 22

15 years ago
I asked Gail about that originally. She commented that we should be sure that an
icon "?" was ok for international as well. The text "?" can be localized as nec
but an icon can't. If feedback from international folks think that an icon "?"
is ok, I think its a good idea.

Comment 23

15 years ago
Using trunk builds 20030324 on winxp, macosx and linux the ? button is there and
brings up the Descriptive text dialog which has a Help button which when clicked
brings up the Help Contents.  This bug as originally written is verfied as
fixed.  The outstanding issue is whether we have the ? be an Icon. I will verify
this and log a new bug for outstanding issue. 

Comment 24

15 years ago
We have bugs coming in for this "?" being confusing and wrong.  See bug 199268
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.