195314 - Forced install regardless of existing installation

Status: VERIFIED FIXED

(Core Graveyard :: Installer: GRE, defect, P1)

Description

[Charles Rosendahl]

20030227 Trunk

The standalone GRE installer doesn't detect that the GRE has already been
installed and performs a forced install unnecesarily.

I believe it was supposed to detect if it was already installed or not before
continuing with installation of gre files, but maybe this behaviour has changed?
 The spec still indicates otherwise.

Comment 1

[Charles Rosendahl]

I hesitate to write a new bug since the following is related:

- specifying a new directory during the gre installation will create the gre in
the new location and overwrite the registry keys of the prior installation.
- effectively 'lose' the previous installation.

Expected behavior:
- detection that a prior installation of the same version exists, perhaps a
prompt to overwrite, and then reinstallation (if forced) into existing directory.
- directory location chooser disabled upon detection of the current version
already installed.

Comment 2

[Charles Rosendahl]

I then installed the mfcembed installer (with GRE), which proceeded to then
overwrite the registry settings of the GRE back to the default location.

All of these are one in the same bug.

Comment 3

[Charles Rosendahl]

Actually it is two bugs.  Let's remove the hardwire for the force option first
though.

Note to self - second bug relates to directory location of installed GRE and
inability to deviate from the already installed location in the absence of a
/reg_path param to the GRE installer.

Comment 4

[Charles Rosendahl]

Please fix before shipping RTM.

Comment 5

[saari (gone)]

this is referring to over-installing the same version of the GRE right, not over
a different version of the GRE, right? Sounds like extra work, but not horrible,
correct? Or will this cause an unnecssary download of the bits again to get the
new GRE customer to run?

Comment 6

[Sean Su]

it should be a one line fix (flipping of a var), but I haven't fully gone over
the possibilites of its effects.  Yes, it would cause an extra unecessary
download of GRE.

Comment 7

[Michael Buckland]

Discussed in edt.  Plussing.

Comment 8

[Samir Gehani]

adt: nsbeta1+/adt2

Comment 9

[Sean Su]

Attachment: patch v1.0

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 123722 [details] [diff] [review]
patch v1.0

a=sspitzer

Comment 11

[Sean Su]

patch checked in.

Comment 12

[Sean Su]

reopening.  found some regressions.  additional patch coming up.

Comment 13

[Sean Su]

Attachment: patch v1.1

additional patch to patch v1.0

Comment 14

[jag (Peter Annema)]

Comment on attachment 123829 [details] [diff] [review]
patch v1.1

sr=jag

Comment 15

[Samir Gehani]

Comment on attachment 123829 [details] [diff] [review]
patch v1.1

> void SetInstallFilesVar(LPSTR szProdDir)
> {
>   char szProgramPath[MAX_BUF];
> 
>-  wsprintf(szProgramPath, "%s%s", szProdDir, sgProduct.szProgramName);
>+  wsprintf(szProgramPath, "%s\\%s", szProdDir, sgProduct.szProgramName);

Please add a check to ensure szProdDir doesn't have a backslash before
appending one.	With that change r=sgehani.

Comment 16

[Sean Su]

Attachment: patch

Comment 17

[Sean Su]

addedum patch checked in.

Comment 18

[Charles Rosendahl]

20030613 branch build.

Verified.  Note that if the gre installation corrupts, the user must perform an
uninstall or delete the GRE directory before running the ns installer.