1953269 - KeyError when viewing a stack with more than 100 diffs

Status: NEW

(Conduit :: Lando, defect, P3)

Description

[Zeid [:zeid]]

Link: https://lando.services.mozilla.com/D240491/
Sentry issue: https://mozilla.sentry.io/issues/6026483807/

This does not appear related to bug 1934615.

Comment 1

[Zeid [:zeid]]

When viewing a stack that has more than 100 diffs in total associated with all the revisions in the stack, Lando can not load the page and instead returns a server error. This is because Phabricator only returns the first 100 diffs, potentially omitting the latest diffs from the results.

For example, if a stack has 11 revisions, and each revision has 10 diffs in its history, this issue will arise. This appears to be a regression of https://github.com/mozilla-conduit/lando-api/pull/438 (no bug).

A workaround is to split the stack in such a way that no one stack has more than 100 diffs, and land each stack separately.