1953277 - [wpt-sync] Sync PR 51271 - Reland "Fix bug where cc clip paths affected intersection behavior"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 51271 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51271
Details from upstream follow.

Claire Chambers <[e-mail]> wrote:

Reland "Fix bug where cc clip paths affected intersection behavior"

This reland includes a fix that prevents the clip rect from not
being properly offset. The previous iteration of this change
mistakenly included needs_mask_based_clip_path_ as a requirement
for offsetting the clip rect, leading to invalid behavior.

The test has been updated with a margin to prevent regressions
on this point.

This is a reland of commit a3e653cb68ffa703751f81c1756de5dc30ae82c2

Original change's description:

Fix bug where cc clip paths affected intersection behavior

This change fixes a bug where intersection observers would behave
differently depending on whether the feature is enabled or not. This
bug occurred because ClipPathClipper::LocalClipPathBoundingBox is
used both for painting and for computing intersections. This change
reverts ClipPathClipper::LocalClipPathBoundingBox back to its prior
behavior, and instead explicitly overrides usages when a cc clip path
animation is present.

Additionally, this change adds an extra flag to the clip paint
property so that it is dectectable in code whether there is a cc
clip path animation requiring an expanded rectangle. This allows
intersection observers to query the real 'precise' rectangle when
necessary, by means of a special flag.

A test is added for this case.

Bug: 394244260

Change-Id: I22024a0264366b055416eebefb91ffec8861e998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6242433
Reviewed-by: Xianzhu Wang \<[e-mail]>
Commit-Queue: Claire Chambers \<[e-mail]>
Reviewed-by: Philip Rogers \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1427364}

Bug: 394244260
Change-Id: I9f7b33231b0a3b87fbf44a3726b7c593eaf6a20b

Reviewed-on: https://chromium-review.googlesource.com/6338287
WPT-Export-Revision: fd67aad29924dcec2f3393a7f8c222fc0b55519f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 51271 applied with additional changes from upstream: 1987fdaadb1afabd5d430f500a0e9200e8d933ac

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=77410f94c4345661cbe548958ca452d67fc8d8b9

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /intersection-observer/clip-path-animation.html [wpt.fyi]
  • clip-path-animation: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6efa26c2d27a
[wpt PR 51271] - Reland "Fix bug where cc clip paths affected intersection behavior", a=testonly

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6efa26c2d27a